-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Notify user of custom label colors and related Dashboard color scheme #17422
Conversation
This is great 👌 |
superset-frontend/src/explore/components/controls/ColorSchemeControl/index.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 suggestion, looks great!
Codecov Report
@@ Coverage Diff @@
## master #17422 +/- ##
==========================================
+ Coverage 76.96% 76.97% +0.01%
==========================================
Files 1041 1041
Lines 56063 56096 +33
Branches 7738 7749 +11
==========================================
+ Hits 43147 43179 +32
- Misses 12658 12659 +1
Partials 258 258
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…e/custom_label_colors_warning
/testenv up |
@geido Ephemeral environment spinning up at http://34.209.144.65:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
… scheme (#17422) * Add alert for custom label colors * Fix duplicate linear scheme * Implement dashboard alert * Remove trailing space * Update Cypress * Simplify check
SUMMARY
This PR:
SUPERSET-UI PR
Requires apache-superset/superset-ui#1467 to be merged to function fully
AFTER DASHBOARD
untitled.dashb.mp4
AFTER EXPLORE
DEV.Vaccine.Ca.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION