Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dependencies for monorepo #17403

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Nov 11, 2021

SUMMARY

add dependencies for monorepo project, this separated PR is to reduce lock file conflicts.

  1. update storybook from 6.3.8 to the latest version
  2. add "lerna": "^3.22.1" into devDependencies
  3. add "react-resizable": "^3.0.4" into devDependencies(it's used by superset-ui stroybook)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #17403 (bedf9eb) into master (7cdd58b) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17403      +/-   ##
==========================================
- Coverage   77.01%   77.01%   -0.01%     
==========================================
  Files        1040     1040              
  Lines       56074    56077       +3     
  Branches     7735     7738       +3     
==========================================
  Hits        43188    43188              
- Misses      12628    12631       +3     
  Partials      258      258              
Flag Coverage Δ
javascript 71.22% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/explore/components/ExploreViewContainer.jsx 2.08% <0.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cdd58b...bedf9eb. Read the comment docs.

@zhaoyongjie zhaoyongjie merged commit ffa55f7 into apache:master Nov 12, 2021
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants