Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump superset-ui v0.18.16 #17251

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Oct 27, 2021

SUMMARY

  1. import ES module from chart-controls
  2. bump superset-ui v0.18.16

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #17251 (b74efb0) into master (4316fe6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17251      +/-   ##
==========================================
- Coverage   76.96%   76.96%   -0.01%     
==========================================
  Files        1037     1037              
  Lines       55608    55606       -2     
  Branches     7588     7588              
==========================================
- Hits        42800    42797       -3     
- Misses      12558    12559       +1     
  Partials      250      250              
Flag Coverage Δ
javascript 71.00% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/explore/components/Control.tsx 76.47% <ø> (ø)
...nts/controls/ConditionalFormattingControl/types.ts 100.00% <ø> (ø)
...end/src/filters/components/GroupBy/controlPanel.ts 100.00% <100.00%> (ø)
...tend/src/filters/components/Select/controlPanel.ts 58.33% <100.00%> (-3.21%) ⬇️
...ontend/src/filters/components/Time/controlPanel.ts 100.00% <100.00%> (ø)
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 87.13% <0.00%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4316fe6...b74efb0. Read the comment docs.

@zhaoyongjie zhaoyongjie merged commit faf7c74 into apache:master Oct 27, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants