Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade highlight.js #17067

Merged
merged 1 commit into from
Oct 15, 2021
Merged

chore: upgrade highlight.js #17067

merged 1 commit into from
Oct 15, 2021

Conversation

suddjian
Copy link
Member

SUMMARY

Responding to CVE in highlight.js by upgrading react-syntax-highlighter

ref #17002

TESTING INSTRUCTIONS

make sure syntax highlighting still works in sqllab

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #17067 (76b5e31) into master (c2e1ab6) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17067   +/-   ##
=======================================
  Coverage   76.88%   76.89%           
=======================================
  Files        1031     1031           
  Lines       55183    55183           
  Branches     7505     7505           
=======================================
+ Hits        42430    42432    +2     
+ Misses      12501    12499    -2     
  Partials      252      252           
Flag Coverage Δ
hive 81.47% <ø> (ø)
javascript 70.82% <ø> (ø)
mysql 81.92% <ø> (ø)
postgres 81.93% <ø> (ø)
presto 81.80% <ø> (+<0.01%) ⬆️
python 82.43% <ø> (+<0.01%) ⬆️
sqlite 81.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 90.37% <0.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e1ab6...76b5e31. Read the comment docs.

@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://54.188.205.186:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@suddjian suddjian merged commit 4a9107d into master Oct 15, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@suddjian suddjian deleted the upgrade-highlight branch October 15, 2021 17:18
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants