-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): Add description to the native filter #17025
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17025 +/- ##
=======================================
Coverage 76.96% 76.96%
=======================================
Files 1037 1037
Lines 55608 55625 +17
Branches 7588 7594 +6
=======================================
+ Hits 42800 42814 +14
- Misses 12558 12561 +3
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS_SET=true FEATURE_DASHBOARD_FILTERS_EXPERIMENTAL=true |
@geido Ephemeral environment spinning up at http://54.218.236.238:8080. Credentials are |
@m-ajay Thanks for the functionality! I noticed a small issue. If you enter an empty char in the description, the tooltip will show up anyway |
We should handle long texts in the description: Screen.Recording.2021-10-08.at.7.30.37.AM.movYou can style the tooltip content with the following to fix it:
|
...ts/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/CascadeFilterControl.test.tsx
Outdated
Show resolved
Hide resolved
...ts/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/CascadeFilterControl.test.tsx
Outdated
Show resolved
Hide resolved
...t-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx
Outdated
Show resolved
Hide resolved
...ashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
Outdated
Show resolved
Hide resolved
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS_SET=true FEATURE_DASHBOARD_FILTERS_EXPERIMENTAL=true |
@michael-s-molina Ephemeral environment spinning up at http://34.222.229.189:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-ajay Requested some changes, especially about the use of the theme variable.
...t-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx
Outdated
Show resolved
Hide resolved
...t-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx
Outdated
Show resolved
Hide resolved
...t-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx
Outdated
Show resolved
Hide resolved
...t-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx
Outdated
Show resolved
Hide resolved
...t-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx
Outdated
Show resolved
Hide resolved
...t-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx
Outdated
Show resolved
Hide resolved
...t-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx
Show resolved
Hide resolved
...t-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution @m-ajay!
yes, thanks for all the hard work and iteration! |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Add a description column to the native filter. Show the description on hover.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION