-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable BQ tests #17017
chore: enable BQ tests #17017
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17017 +/- ##
==========================================
+ Coverage 76.93% 77.02% +0.08%
==========================================
Files 1030 1030
Lines 55085 55801 +716
Branches 7477 7477
==========================================
+ Hits 42382 42980 +598
- Misses 12452 12570 +118
Partials 251 251
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
4cfc3ba
to
3f17ac9
Compare
3f17ac9
to
442155b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. As we add more comprehensive tests to other engine specs, we might later want to break out a separate set of testing requirements and even a separate test suite if the dependency list becomes huge.
SUMMARY
In #16822 I added a couple unit tests for BigQuery that would only run if the optional dependencies were installed, as well as some "generic" tests based on SQLite for when the dependencies were not found.
In this PR I added the BigQuery dependencies to our test dependencies, so that the tests run on CI. I also removed the generic SQLite tests, since they're no longer needed.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Run unit tests.
ADDITIONAL INFORMATION