Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable BQ tests #17017

Merged
merged 1 commit into from
Oct 14, 2021
Merged

chore: enable BQ tests #17017

merged 1 commit into from
Oct 14, 2021

Conversation

betodealmeida
Copy link
Member

SUMMARY

In #16822 I added a couple unit tests for BigQuery that would only run if the optional dependencies were installed, as well as some "generic" tests based on SQLite for when the dependencies were not found.

In this PR I added the BigQuery dependencies to our test dependencies, so that the tests run on CI. I also removed the generic SQLite tests, since they're no longer needed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Run unit tests.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro closed this Oct 8, 2021
@villebro villebro reopened this Oct 8, 2021
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #17017 (4cfc3ba) into master (5f73ca8) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 4cfc3ba differs from pull request most recent head 442155b. Consider uploading reports for the commit 442155b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17017      +/-   ##
==========================================
+ Coverage   76.93%   77.02%   +0.08%     
==========================================
  Files        1030     1030              
  Lines       55085    55801     +716     
  Branches     7477     7477              
==========================================
+ Hits        42382    42980     +598     
- Misses      12452    12570     +118     
  Partials      251      251              
Flag Coverage Δ
hive 81.44% <ø> (-0.03%) ⬇️
javascript 70.89% <ø> (ø)
mysql 81.90% <ø> (-0.03%) ⬇️
postgres 82.12% <ø> (+0.18%) ⬆️
presto ?
python 82.46% <ø> (+0.02%) ⬆️
sqlite 81.58% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 84.30% <0.00%> (-6.07%) ⬇️
superset/db_engine_specs/bigquery.py 81.70% <0.00%> (-4.27%) ⬇️
superset/connectors/sqla/models.py 85.83% <0.00%> (-1.42%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️
superset/views/database/views.py 89.34% <0.00%> (+0.93%) ⬆️
superset/db_engine_specs/gsheets.py 77.47% <0.00%> (+2.47%) ⬆️
superset/views/core.py 79.60% <0.00%> (+2.69%) ⬆️
superset/connectors/base/models.py 91.86% <0.00%> (+3.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f73ca8...442155b. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As we add more comprehensive tests to other engine specs, we might later want to break out a separate set of testing requirements and even a separate test suite if the dependency list becomes huge.

@betodealmeida betodealmeida merged commit 83a2f83 into master Oct 14, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@villebro villebro deleted the bq_test branch May 16, 2022 16:04
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants