-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removing use of supersetTheme in favor of ThemeProvider #17000
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17000 +/- ##
=======================================
Coverage 76.93% 76.93%
=======================================
Files 1030 1030
Lines 55031 55033 +2
Branches 7465 7465
=======================================
+ Hits 42336 42340 +4
+ Misses 12441 12439 -2
Partials 254 254
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
I'm going to do some quick investigation into this |
It appears this has been added some time ago, but never implemented: https://issues.apache.org/jira/browse/INFRA-18241 I wonder if we should just pull it (pun intended)? |
Actually, let's not remove it, this could be leveraged to customize our PR review process more. I'll open a draft to test how this could be used. |
SUMMARY
For ErrorAlert and BasicErrorAlert this PR removes direct use of
supersetTheme
in favor of theuseTheme
hook and theThemeProvider
component.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
there should be no discernable change
TESTING INSTRUCTIONS
Make sure errors look OK in the ephemeral environment.
ADDITIONAL INFORMATION