Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dashboard standalone class not added when parameter set #16619

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

trepmag
Copy link
Contributor

@trepmag trepmag commented Sep 7, 2021

SUMMARY

When the standalone url parameter is set the dashboard html body class should be set to standalone.

This was integrated in issue #6811.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and reproduced bug + verified that the fix works. Thanks so much for this! One minor nit - I'm going to merge later today, but if you happen to have time to make the proposed change that would make my linting OCD happier 🙂

@@ -1912,6 +1914,7 @@ def dashboard(
bootstrap_data=json.dumps(
bootstrap_data, default=utils.pessimistic_json_iso_dttm_ser
),
standalone_mode=standalone_mode,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: since standalone_mode isn't being reused, I'd prefer to place it inline here, like

standalone_mode=ReservedUrlParameters.is_standalone_mode(),

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 16, 2022
@stale stale bot removed the inactive Inactive for >= 30 days label Apr 20, 2022
@villebro
Copy link
Member

@trepmag sorry for dropping the ball on this - I rebased to retrigger CI and will merge today if CI passes.

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #16619 (f92e124) into master (231716c) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head f92e124 differs from pull request most recent head ca7dc77. Consider uploading reports for the commit ca7dc77 to get more accurate results

@@            Coverage Diff             @@
##           master   #16619      +/-   ##
==========================================
- Coverage   66.51%   66.34%   -0.17%     
==========================================
  Files        1690     1690              
  Lines       64730    64731       +1     
  Branches     6656     6656              
==========================================
- Hits        43054    42947     -107     
- Misses      19977    20085     +108     
  Partials     1699     1699              
Flag Coverage Δ
hive ?
mysql 81.89% <100.00%> (+<0.01%) ⬆️
postgres 81.93% <100.00%> (+<0.01%) ⬆️
presto ?
python 82.02% <100.00%> (-0.34%) ⬇️
sqlite 81.70% <100.00%> (+<0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/SqlLab/components/QueryTable/index.tsx 69.64% <ø> (ø)
superset/views/core.py 77.02% <100.00%> (+0.01%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.11% <0.00%> (-15.71%) ⬇️
superset/db_engine_specs/presto.py 83.64% <0.00%> (-5.39%) ⬇️
superset/connectors/sqla/models.py 88.84% <0.00%> (-1.20%) ⬇️
superset/initialization/__init__.py 91.37% <0.00%> (-0.35%) ⬇️
superset/db_engine_specs/base.py 88.01% <0.00%> (-0.34%) ⬇️
superset/models/core.py 89.09% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 89.71% <0.00%> (-0.12%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 231716c...ca7dc77. Read the comment docs.

@villebro villebro merged commit 5134c63 into apache:master Apr 20, 2022
villebro pushed a commit that referenced this pull request Apr 25, 2022
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
(cherry picked from commit 5134c63)
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
…16619)

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
…16619)

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants