Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): Let users re-arrange native filters #16154

Merged
merged 56 commits into from
Oct 15, 2021

Conversation

m-ajay
Copy link
Contributor

@m-ajay m-ajay commented Aug 9, 2021

SUMMARY

Allows users to re-arrange the dashboard native filters

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

ezgif com-gif-maker

TESTING INSTRUCTIONS

  • Click Edit icon (✏️) in native filters section on the left side of the dashboard
  • Re-arrange the native filters in the opened modal box
  • Save and verify that the order has changed in the UI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #16154 (06bf6eb) into master (5e85f48) will increase coverage by 0.02%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16154      +/-   ##
==========================================
+ Coverage   76.88%   76.91%   +0.02%     
==========================================
  Files        1031     1034       +3     
  Lines       55183    55381     +198     
  Branches     7505     7545      +40     
==========================================
+ Hits        42430    42594     +164     
- Misses      12501    12538      +37     
+ Partials      252      249       -3     
Flag Coverage Δ
javascript 70.90% <76.47%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ilters/FilterBar/FilterConfigurationLink/index.tsx 100.00% <ø> (ø)
...mponents/nativeFilters/FiltersConfigModal/state.ts 81.25% <0.00%> (+4.77%) ⬆️
...mponents/nativeFilters/FiltersConfigModal/utils.ts 65.64% <55.76%> (-4.73%) ⬇️
...ilters/FiltersConfigModal/FilterTitleContainer.tsx 64.51% <64.51%> (ø)
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 69.25% <72.22%> (-2.36%) ⬇️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 87.50% <85.48%> (-1.85%) ⬇️
...ilters/FilterBar/FilterControls/FilterControls.tsx 80.00% <87.50%> (ø)
...tiveFilters/FiltersConfigModal/FilterTitlePane.tsx 92.00% <92.00%> (ø)
...tiveFilters/FiltersConfigModal/DraggableFilter.tsx 92.30% <92.30%> (ø)
...omponents/nativeFilters/FilterBar/Header/index.tsx 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e85f48...06bf6eb. Read the comment docs.

@junlincc
Copy link
Member

junlincc commented Aug 9, 2021

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2021

@junlincc Ephemeral environment spinning up at http://34.209.125.69:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@jinghua-qa
Copy link
Member

I have tested in the test environment, the drag and drop is not accurate, it always drop the filter to the bottom no matter i move up or move down, some time i just want to change the filter position from 1st to 2nd and it was dropped to the last

Screen.Recording.2021-08-09.at.3.56.13.PM.mov

@junlincc junlincc added the hold:testing! On hold for testing label Aug 10, 2021
@m-ajay
Copy link
Contributor Author

m-ajay commented Aug 10, 2021

@jinghua-qa Thanks for testing. It happens when we newly add filters and try re-arrange them. I have fixed it now.

@rusackas
Copy link
Member

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://34.217.68.142:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@graceguo-supercat
Copy link

@m-ajay i found a issue in the latest build: for the last added component, its column value sometimes now showing up:
JBdRVAlaoq

@michael-s-molina
Copy link
Member

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

@github-actions
Copy link
Contributor

@michael-s-molina Ephemeral environment spinning up at http://35.85.223.220:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@michael-s-molina
Copy link
Member

I found this weird bug after canceling:

Screen.Recording.2021-10-14.at.3.52.44.PM.mov

@michael-s-molina
Copy link
Member

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

@github-actions
Copy link
Contributor

@michael-s-molina Ephemeral environment spinning up at http://34.212.76.74:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@jinghua-qa
Copy link
Member

Saw unexpected error when applying filters for different scope in multiple tabs.

Repo steps:
precondition: using video game sales dashboard
1, create value filter for platform and apply to tab 'overview'
2, create value filter for genre and apply to tab 'explore trends'
3, create time range filter and apply for all tabs
4,go to the dashboard and click on each tab to check filter scope
5, see unexpected error

Screen.Recording.2021-10-14.at.2.27.22.PM.mov

@michael-s-molina
Copy link
Member

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

@github-actions
Copy link
Contributor

@michael-s-molina Ephemeral environment spinning up at http://52.37.179.33:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you so much @m-ajay for your hard work and for addressing all the comments. This feature really benefits the user experience and it's a nice addition to the product. 👏🏼 🚀

@graceguo-supercat
Copy link

@michael-s-molina @jinghua-qa thanks for the hard work!!

@graceguo-supercat graceguo-supercat merged commit 9e6d5fc into apache:master Oct 15, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* feat. flag: ON

* refactor filter tabs

* WIP

* Drag and Rearrange, styling

* refactoring dnd code

* Add apache license header

* Fix bug reported during PR review

* Minor fix on remove

* turn off filters

* Fix status

* Fix a test

* Address PR comments

* iSort fixes

* Add type key to the new filters

* Fix wrong attribute

* indent

* PR comments

* PR comments

* Fix failing tests

* Styling

* Fix remove filter

* Fix the drag issue

* Save works

* fix

* Write tests

* Style changes

* New Icon

* Grab & Grabbing Cursor

* Commented out code

* Fix tests, fix CI

* Fix failing tests

* Fix test

* Style fixes

* portal nodes dependency

* More style fixes

* PR comments

* add unique ids to collapse panels

* Filter removal bug fixed

* PR comments

* Fix test warnings

* delete filter tabs

* Fix the breaking test

* Fix warnings

* Fix the weird bug on cancel

* refactor

* Fix broken scope
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels hold:testing! On hold for testing need:qa-review Requires QA review size/XXL 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants