feat: show build number value in the About if present in the config #14955
Conversation
… in the About area, if present.
cccs-joel
changed the title
|
Hi, do I need to action something from my side to speed things up? |
|
My mistake for reviewing, apologies. |
|
How can we get the ball rolling with this PR? @junlincc |
|
Could you please explain your use case and why this is needed? Does the current version config, kept in package.json, not meet your needs? |
|
Sure, we want to qualify/augment the version number available in the config by adding a build number shown in the about. Would be useful for our QA people. That number in our case is the date we build the image and a sequence number, too long to fit on the same line of the Superset version. |
|
Ok, looks like CI is failing. Can you add a default value to config.py and a comment explaining what this config does and how to use it? |
superset/views/base.py
Outdated
| try: | ||
| build_number = appbuilder.app.config["BUILD_NUMBER"] | ||
| except Exception as ex: | ||
| logger.debug("BUILD_NUMBER is missing from the config", ex) |
There was a problem hiding this comment.
this shouldn't be necessary if you add a default value in config.py, (either empty string or None). Config values should never be undefined.
There was a problem hiding this comment.
Anything required at our end at this point?
There was a problem hiding this comment.
Yes, you need to get CI passing before we can merge
Codecov Report
@@ Coverage Diff @@
## master #14955 +/- ##
==========================================
- Coverage 76.71% 76.50% -0.22%
==========================================
Files 1002 1002
Lines 53823 53829 +6
Branches 7287 7291 +4
==========================================
- Hits 41292 41183 -109
- Misses 12291 12406 +115
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…of None, removed try catch block as config values are always defined.
|
There is still a failing check, no clue why. All I get is: T_he operation was canceled._ for Python Misc / python-lint |
|
Yes. I think there’s an issue with a pylint upgrade that’s currently affecting all PRs. |
|
@cccs-joel you might have to rebase your branch to fix, seems like some of the more recently opened PRs are not having issues. |
|
@nytai I just merged master into my branch once again, hopefully that will trigger the checks and they will all pass. |
|
@nytai Ok, that did the trick, all checks are now passing. Can someone merge? |
mistercrunch
added
🍒 1.3.1
🍒 1.3.2
🏷️ bot
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Add a variable called BUILD_NUMBER in the config.py, the value should be displayed in the About section underneath the version/sha. No build information is shown if there is no variable BUILD_NUMBER in the config.py file.
ADDITIONAL INFORMATION