-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update kubernetes.mdx #14512
fix: update kubernetes.mdx #14512
Conversation
|
||
```yaml | ||
additionalRequirements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
additionalRequiremnts
are no longer supported value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no this broke, please see #14188 and #13917. This PR may be a moot point if this chart is released up, see #14188 (comment) which is a comment from 14 days ago.
apt-get update -y &&\ | ||
apt-get install -y --no-install-recommends nano &&\ | ||
rm -rf /var/lib/apt/lists/* | ||
pip install psycopg2==2.8.5 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which versions are supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are, I think the important thing here is to get a working demo, it should be up to the end-user to determine what packages they want to install in their own superset install.
sorry this took a while @mvoitko, I made your requested changes, but this PR may be moot per my comment above. Thanks for this awesome lib! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, thank you for the PR. Just left a small comment
@@ -94,25 +94,18 @@ postgresql: | |||
|
|||
#### Dependencies | |||
|
|||
You can specify pip packages to be installed before startup, e.g. to install extra database drivers: | |||
You can specify pip packages to be installed before startup. The following example installs the Big Query and Elasticsearch database drivers so that you can connect to those datasources in your Superset installation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's include the comment on the values config file:
# Install additional packages and do any other bootstrap configuration in this script
# For production clusters it's recommended to build own image with this step done in CI
Since we should not encourage the use of a bootstrap script to install OS or python packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comment, but ready to go
SUMMARY
Update the Helm Kubernetes instruction to use
bootstrapScript
. In the helm values file,additionalRequirements
currently referenced in the spec, does not exist.ADDITIONAL INFORMATION