feat(alerts): apply SQL limit to all alerts #13150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13150 +/- ##
===========================================
+ Coverage 53.06% 64.01% +10.95%
===========================================
Files 489 960 +471
Lines 17314 44815 +27501
Branches 4482 4072 -410
===========================================
+ Hits 9187 28690 +19503
- Misses 8127 16125 +7998
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
willbarrett
reviewed
Feb 16, 2021
superset/reports/commands/alert.py
Outdated
| @@ -117,7 +117,10 @@ def validate(self) -> None: | |||
| ) | |||
| rendered_sql = sql_template.process_template(self._report_schedule.sql) | |||
| try: | |||
| df = self._report_schedule.database.get_df(rendered_sql) | |||
| limited_rendered_sql = self._report_schedule.database.apply_limit_to_sql( | |||
| rendered_sql, 1 | |||
There was a problem hiding this comment.
I'm wondering if we should set the limit to 2 - the system expects a single row and raises an error if multiple rows are returned. This error could surface an issue with the query, or the data being accessed. Setting the limit to 1 changes the behavior of the query in a way that could hide issues.
willbarrett
approved these changes
Feb 17, 2021
dpgaspar
deleted the
danielgaspar/ch5154/make-sure-the-sql-statement-in-the-condition
branch
This was referenced Nov 30, 2023
This was referenced Dec 6, 2023
mistercrunch
added
🏷️ bot
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Applies a limit of 2 to all alerts. Running huge queries on the DB by mistake may cause performance impact.
ADDITIONAL INFORMATION