-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change test environment to jsdom #13149
chore: change test environment to jsdom #13149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Do you know what's the benefit of setting |
@ktmud Setting The error happens when |
Thanks for the clarification! |
SUMMARY
Change test environment to
jsdom
(default when installed) so we can use react-testing-library functions that listen for DOM mutations like findBy.Test environment with
enzyme
option was causing TypeError: MutationObserver is not a constructor@ktmud @rusackas @geido
Add to #13079
TEST PLAN
1 - Execute all jest tests
2 - All tests should pass
ADDITIONAL INFORMATION