fix: Disabled state button transition time #13008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
approved these changes
Feb 8, 2021
| @@ -91,25 +91,32 @@ const RunQueryActionButton = ({ | |||
| ? (DropdownButton as React.FC) | |||
| : Button; | |||
|
|
|||
| const isDisabled = !sql.trim(); | |||
There was a problem hiding this comment.
Nice, this is way more readable now, and the intent is clear!
There was a problem hiding this comment.
Thank you! Though this was actually Elizabeth's suggestion. So can't take all the credit.
etr2460
approved these changes
Feb 8, 2021
| @@ -69,6 +69,8 @@ const onClick = ( | |||
| const StyledButton = styled.span` | |||
| button { | |||
| line-height: 13px; | |||
| transition: background-color 0ms; | |||
| // this is to over ride a previous transition built into the component | |||
There was a problem hiding this comment.
maybe add the comment above the transition line? I think that's how we usually comment stuff in the repo
|
Added both these. Thank you again.
|
|
@AAfghahi we just need a rebase on this before we can merge it. |
Ok, will do first thing in the morning. |
AAfghahi
force-pushed
the
disabled-state-button
branch
from
6451b5b
to
b8f7b4b
Compare
AAfghahi
force-pushed
the
disabled-state-button
branch
from
b8f7b4b
to
40f15cd
Compare
AAfghahi
changed the title
I think it should be good now? |
|
Tested manually and it looks great. Thanks @AAfghahi! |
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Feb 14, 2021
* button fix * tooltips disabled when it is disabled, border width changed * added isDisabled to tooltip * worked on transition times * cleaned up transition to be local instead of global * made it local * linted * trying to resolve a conflict
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Feb 14, 2021
* master: (30 commits) refactor(native-filters): decouple params from filter config modal (first phase) (apache#13021) fix(native-filters): set currentValue null when empty (apache#13000) Custom superset_config.py + secret envs (apache#13096) Update http error code from 400 to 403 (apache#13061) feat(native-filters): add storybook entry for select filter (apache#13005) feat(native-filters): Time native filter (apache#12992) Force pod restart on config changes (apache#13056) feat(cross-filters): add cross filters (apache#12662) fix(explore): Enable selecting an option not included in suggestions (apache#13029) Improves RTL configuration (apache#13079) Added a note about the ! prefix for breaking changes to CONTRIBUTING.md (apache#13083) chore: lock down npm to v6 (apache#13069) fix: API tests, make them possible to run independently again (apache#13076) fix: add config to disable dataset ownership on the old api (apache#13051) add required * indicator to message content/notif method (apache#12931) fix: Retroactively add granularity param to charts (apache#12960) fix(ci): multiline regex in change detection (apache#13075) feat(style): hide dashboard header by url parameter (apache#12918) fix(explore): pie chart label bugs (apache#13052) fix: Disabled state button transition time (apache#13008) ...
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Transition time was off between the SVG icon and the Run button. Used css transition delays to make it much smoother.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
107099586-ebab7500-67c6-11eb-94a0-dd87f325fcc8.mp4
After:
button.mov
TEST PLAN
ADDITIONAL INFORMATION