-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add alerts and report to default config #12999
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12999 +/- ##
==========================================
+ Coverage 63.21% 66.97% +3.76%
==========================================
Files 1025 489 -536
Lines 50291 28756 -21535
Branches 5241 0 -5241
==========================================
- Hits 31790 19259 -12531
+ Misses 18289 9497 -8792
+ Partials 212 0 -212
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Is docker-compose running beat or celery with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM. We should add some more docs and/or configs so users know how to run alerts and reports. We can address in another PR.
* master: fix: UI toast typo (apache#13026) feat(db engines): add support for Opendistro Elasticsearch (AWS ES) (apache#12602) fix(build): black failing on master, add to required checks (apache#13039) fix: time filter db migration optimization (apache#13015) fix: untranslated text content of Dashboard page (apache#13024) fix(ci): remove signature requirements for commits to master (apache#13034) fix: add alerts and report to default config (apache#12999) docs(changelog): add entries for 1.0.1 (apache#12981) ci: skip cypress if no code changes (apache#12982) chore: add cypress required checks for branch protection (apache#12970) Refresh dashboard list after bulk delete (apache#12945) Updates storybook to version 6.1.17 (apache#13014) feat: Save datapanel state in local storage (apache#12996) fix: added text and changed margins (apache#12923) chore: Swap Slack Url 2 more places (apache#13004)
SUMMARY
Adds alerts and reports beat schedule by default (basically helps our users)
ADDITIONAL INFORMATION