Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: long labels now truncate with ellipsis #11400

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

rusackas
Copy link
Member

SUMMARY

Some labels had long text that was causing layout issues. Now they stop at 100% of their parent's width, and truncate the text with an ellipsis.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Oct 22, 2020

Codecov Report

Merging #11400 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11400   +/-   ##
=======================================
  Coverage   66.07%   66.07%           
=======================================
  Files         840      840           
  Lines       40093    40093           
  Branches     3685     3685           
=======================================
+ Hits        26490    26493    +3     
+ Misses      13502    13499    -3     
  Partials      101      101           
Flag Coverage Δ
#cypress 56.32% <ø> (+0.02%) ⬆️
#javascript 62.95% <ø> (ø)
#python 61.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Label/index.tsx 100.00% <ø> (ø)
.../src/explore/components/AdhocMetricEditPopover.jsx 69.86% <0.00%> (+4.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b92b2...9d7660b. Read the comment docs.

@nytai
Copy link
Member

nytai commented Oct 23, 2020

retriggering CI

@nytai nytai closed this Oct 23, 2020
@nytai nytai reopened this Oct 23, 2020
@nytai nytai merged commit d64260f into apache:master Oct 23, 2020
@nytai nytai deleted the labels-truncate-overflow branch October 23, 2020 01:35
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants