-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: set up client-side redirects from previous era docs urls #10921
Conversation
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The #
actually makes this into giant header text when viewing the readme on github. The [//]: #
doesn't work as expected either. If you want to sink a little time into figuring out how to make this a proper markdown comment block, that'd be appreciated. Both of the aforementioned treatments don't work as intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird! I did this via the Github merge conflict UI, hmm I'l fix locally!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it's the <!--
syntax now... that was causing other errors for me (couldn't run the build script), but maybe you'll have better luck?
LGTG once you fix CI stuff. |
https://chris.beams.io/posts/git-commit/ |
…e#10921) * one simple redirect, as a test * adding license to header * painstakingly added SEO redirects! * addressed feedback and ran lint-fix! * lets try newline again! * Revert "lets try newline again!" This reverts commit 20f89bd. * Revert "Revert "lets try newline again!"" This reverts commit e441edc. * wait... there were TWO newlines? Co-authored-by: Evan Rusackas <evan@preset.io>
SUMMARY
Routes for old docs take people to dead pages. This ensures that they're taken to the page most closely matching the original page.
See route mapping doc: https://docs.google.com/document/d/1Yv4f2n_1lL5GHaQkpvG1imCHS7XVKJmyIqoudXvFygc/edit
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION