Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min bar width for NVD3 charts not maintained on chart with few columns. #7409

Closed
3 tasks done
john-wormington-sp opened this issue Apr 29, 2019 · 4 comments
Closed
3 tasks done
Labels
!deprecated-label:bug Deprecated label - Use #bug instead inactive Inactive for >= 30 days

Comments

@john-wormington-sp
Copy link

Bar Chart column width can become unusable when resizing browser. Long x-axis names exacerbates the issue. The issue appears to be tied to the number of columns in the bar chart and the allotted chart width. To try and limit the ui issues the screen shots below make use of a change to truncate the long x-axis names: apache-superset/superset-ui-plugins#21

This issue seems similar: #629

Expected results

Minimum bar width maintained

Actual results

Bar Chart columns squished

Screenshots

Bar Chart with few columns, squished down vs Bar Chart with more columns that overflow outside the container.

bar chart column width

How to reproduce the bug

  1. Create a Dashboard with two bar charts, one with few columns, one with many columns.
  2. Choose a chart width that is small, ex: chart position json meta width = 3
  3. Resize (decreasing) browser window to see the chart render smaller and smaller column width until they are unusable on the chart with few columns. While the chart with many columns overflows

Environment

  • superset version: [v0.999.0dev, master]

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar. Added links to related issues or fixes but they differ or do not fix the issue related to the number of x-axis columns.
@issue-label-bot issue-label-bot bot added the !deprecated-label:bug Deprecated label - Use #bug instead label Apr 29, 2019
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.84. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@stale
Copy link

stale bot commented Jun 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Jun 28, 2019
@nbsbhat
Copy link

nbsbhat commented Jul 4, 2019

Is there a way to get around this issue?
Also is it possible to set a max width when number of bars are fever or only one or two - either with horizontal or vertical bar charts

@stale stale bot removed the inactive Inactive for >= 30 days label Jul 4, 2019
@stale
Copy link

stale bot commented Sep 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Sep 2, 2019
@stale stale bot closed this as completed Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead inactive Inactive for >= 30 days
Projects
None yet
Development

No branches or pull requests

2 participants