Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty "Color Scheme" dropdown #5889

Closed
mistercrunch opened this issue Sep 13, 2018 · 4 comments · Fixed by #5891
Closed

Empty "Color Scheme" dropdown #5889

mistercrunch opened this issue Sep 13, 2018 · 4 comments · Fixed by #5891

Comments

@mistercrunch
Copy link
Member

mistercrunch commented Sep 13, 2018 •
edited
Loading

@kristw is this related to your recent work on colors? #5815

screen shot 2018-09-13 at 12 11 00 pm
@kristw
Copy link
Contributor

kristw commented Sep 13, 2018

Yes, I will take care of it. Seem like the control calls getAllSchemes() before schemes are registered.

@kristw
Copy link
Contributor

kristw commented Sep 13, 2018

I think this is related to #5883 . Will investigate further and fix.

@kristw kristw mentioned this issue Sep 13, 2018
Merged
@kristw
Copy link
Contributor

kristw commented Sep 13, 2018

I will fix the ColorSchemeControl directly. Webpack may do something more complicated than I thought.

@kristw kristw mentioned this issue Sep 13, 2018
Merged
@mistercrunch
Copy link
Member Author

Thanks for fixing this!

@laxmanraparthi laxmanraparthi mentioned this issue Oct 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[bugfix] Fix color scheme picker kristw/incubator-superset
2 participants
@mistercrunch @kristw