Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIP-8] Add UI component for user to select and persist category color from Dashboard #5887

Closed
3 tasks done
graceguo-supercat opened this issue Sep 13, 2018 · 2 comments
Closed
3 tasks done
Labels
sip Superset Improvement Proposal

Comments

@graceguo-supercat
Copy link

graceguo-supercat commented Sep 13, 2018

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if any
  • I have reproduced the issue with at least the latest released version of superset
  • I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

0.27

Expected results

  • User can use a color picker to choose specific color for chart category.
  • With or without define color for chart, each time we refresh dashboard should see same category with a same color.

Actual results

m2ojecxt59

Steps to reproduce

Refresh dashboard a few times.

Design

screenshot_2018-09-10_17 46 58

Implementation

  • Reuse existed API to store category color in dashboard metadata
  • refactory color assignment logic [Improve categorical color management #5815]
  • Add color picker UI component (shown in design section) as part of dashboard builder control.

@williaster @elibrumbaugh @kristw @mistercrunch @michellethomas @john-bodley @betodealmeida @xtinec

@graceguo-supercat graceguo-supercat changed the title [SIP-8] Add UI component for user to select and persist chart color from Dashboard [SIP-8] Add UI component for user to select and persist category color from Dashboard Sep 13, 2018
@graceguo-supercat graceguo-supercat added the sip Superset Improvement Proposal label Sep 13, 2018
@stale
Copy link

stale bot commented Apr 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@junlincc
Copy link
Member

closing the SIP as we added the project to roadmap apache-superset/superset-roadmap#110

cc @mihir174 this project requires design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sip Superset Improvement Proposal
Projects
Status: Implemented / Done
Development

No branches or pull requests

3 participants