-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
superset_node build failure @nx/nx-linux-x64-gnu missing module #29658
Comments
I got this too. Manually adding it as a devDependency seems to work as a workaround for me. diff --git a/superset-frontend/package.json b/superset-frontend/package.json
index bb7a2face8..bba6bef5a7 100644
--- a/superset-frontend/package.json
+++ b/superset-frontend/package.json
@@ -226,6 +226,7 @@
"@emotion/jest": "^11.11.0",
"@hot-loader/react-dom": "^16.14.0",
"@istanbuljs/nyc-config-typescript": "^1.0.1",
+ "@nx/nx-linux-x64-gnu": "^18.3.5",
"@storybook/addon-actions": "^8.1.11",
"@storybook/addon-controls": "^8.1.11",
"@storybook/addon-essentials": "^8.1.11", |
@hainenber have you run into this, or do you see any obvious solutions? |
I've gotten around this by debumping to |
heya folks, apologies for inconvenience brought upon. I'm checking this issue, was a busy week previously :D |
The https://github.com/apache/superset/blob/master/docker/docker-frontend.sh#L26-L29 |
This wouldn't work on larger scale since people's machines are diverse in terms of OS and architecture. Here's what happened on my machine.
There's a heavy workaround in the linked PR but if that isn't ideal, I'll downgrade to Lerna 6 asap. |
Bug description
When trying to deploy using docker compose, I'm receiving a missing module error. It appears this bug first emerged in PR #29419 specifically commit hash: c30ca53
How to reproduce the bug
Checkout latest master branch
Clear the docker cache of previous superset images
Rebuild images with docker compose build
Run docker compose up
Screenshots/recordings
Superset version
master / latest-dev
Python version
3.10
Node version
18 or greater
Browser
Chrome
Additional context
As a workaround to other build errors, I've edited Dockerfile line 27 from
ARG NPM_BUILD_CMD="build"
to
ARG NPM_BUILD_CMD="build-dev"
Checklist
The text was updated successfully, but these errors were encountered: