Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem when creating dataset/chart/dashboard if database is Trino with TRINO_EXPAND_ROWS #27939

Open
2 of 3 tasks
JustGui opened this issue Apr 8, 2024 · 0 comments
Open
2 of 3 tasks
Assignees
Labels
data:connect:trino Related to Trino

Comments

@JustGui
Copy link

JustGui commented Apr 8, 2024

Bug description

Importing a dataset/chart/dashboard linked to a Trino database with TRINO_EXPAND_ROWS=True and "Row expansion in schema" activated, returns an error via the API & Superset interface.

Screenshot 2024-04-08 at 14 34 00

To avoid this error, you need to remove the following lines from the YAML file before importing:

  schema_options:
    expand_rows: true

Superset API shouldn't break when new extras are added to a database as the database itself isn't altered when we remove existing extras from the YAML file and import the dataset with this altered schema. It seems like the extra in the YAML doesn't really matter at the end, so it shouldn't break the API.

Thx!

How to reproduce the bug

  1. Add the feature flag "TRINO_EXPAND_ROWS": True
  2. Enable "Row expansion in schema" on a Trino database
    Screenshot 2024-04-08 at 14 24 41
  3. Export a dataset as a zip using this database via the interface
  4. Import again this dataset (the same zip file)
  5. After validating, instead of proposing to overwrite your dataset, it will return an error
    Screenshot 2024-04-08 at 14 34 00

Screenshots/recordings

No response

Superset version

master / latest-dev

Python version

3.10

Node version

16

Browser

Firefox

Additional context

No response

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:connect:trino Related to Trino
Projects
None yet
Development

No branches or pull requests

4 participants