Charts Fullscreen issue when filter pane is collapsed

[hrnori]

There is an issue with the charts full screen option when the vertical filter pane is collapsed. The process to get this bug is a bit specific but it has come across the users. If the dashboard is first loaded with the filter pane open, and you do a full screen on any chart the app will behave as expected. The issue comes when you exit the full screen and close the filter pane and do again a full screen, this time the chart won't do a full screen but instead all the charts will start having a sort of clipping bug over other components in the dashboard, and the chart might increase in size but won't do the full screen.

How to reproduce the bug

1. Go to any dashboard
2. If the dashboard has the vertical filter pane closed, open it and refresh the page
3. Once the dashboard page has the filter pane open on start, do a full screen on any chart
4. Once the chart is in full screen, minimize the chart
5. Click on the hide filter pane button
6. Try again to do full screen on any chart

Expected results

second time doing a full screen (filter pane closed) we should only see the chart

Actual results

second time doing a full screen (filter pane closed) the chart increase in size (not it's canvas) but we can still see the rest of the dashboard

Screenshots

Additional screenshots to display the bug on other sample dashboards

Environment

• browser type and version: Google Chrome Version 114.0.5735.198 (Official Build) (64-bit)
• superset version: 2.1.0
• python version: 3.8.12
• node.js version: 16.14.2

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

This issue does not occur if the filter pane is collapsed when the dashboard is loaded.
If the filter pane is open on start and you close and open it sequentially, you would not have the bug either.

[rusackas]

Hah... yep, this is still an issue in current Superset. I'm surprised I haven't seen this one. Let's leave it open in hopes of a frontend person looking for an approachable fix :)

[surapuramakhil]

@rusackas is this issue still exists?

I tried to do repo but unable to do so

REC-20240425153528.mp4

[hlvhe]

Hi, still encounter the issue, can I have a look to fix it?

[sambhav2612]

hey @rusackas is this something still being looked at? - I can see a PR (#28428) pending review