package 'pkg_resource' is deprecated in favor of importlib

[sebastianliebscher]

The package pkg_resource is officially deprecated in favor of importlib: https://setuptools.pypa.io/en/latest/pkg_resources.html

Use of pkg_resources is discouraged in favor of importlib.resources, importlib.metadata, and their backports (resources, metadata). Please consider using those libraries instead of pkg_resources.

[sebastianliebscher]

I think this issue is fixed when part 2 of #24578 gets merged @cwegener

[cwegener]

I still have one last step to go before this is complete, which is to change the UPLOAD_FOLDER logic in superset.config which currently relies on said setuptools module.

The won't be any ceremonious removal of the setuptools runtime dependency from the requires list though, as that runtime dependency is not explicitly declared in the metadata at all anyway. But instead superset simply presumes that setuptools is a runtime dependency that is installed everywhere.

[rusackas]

@cwegener @sebastianliebscher can you advise us on the current status of this one?

[cwegener]

UPLOAD_FOLDER logic still needs to be changed in order to get rid of this last remaining pkg_resources import ...

superset/superset/config.py

Line 79 in ce0b70c

BASE_DIR = pkg_resources.resource_filename("superset", "")

It's an easy change to do, but will be a breaking change.

I'll create a PR for it.

[rusackas]

We can slap a HOLD label on it, and line up the shot for an eventual 5.0 :D

[cwegener]

We can slap a HOLD label on it, and line up the shot for an eventual 5.0 :D

Sounds good to me.

[rusackas]

Hey @cwegener - long time no talk :)

We're getting close to 5.0 now, so I'd say feel free to open a PR if/when you have bandwidth. We're at the phase where proposals/consensus will be coming through, and merging these in-progress/held-back things won't be far behind.