Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impossible to have translation for DatePicker #20062

Closed
aehanno opened this issue May 13, 2022 · 2 comments · Fixed by #20063
Closed

Impossible to have translation for DatePicker #20062

aehanno opened this issue May 13, 2022 · 2 comments · Fixed by #20063
Labels
#bug Bug report

Comments

@aehanno
Copy link
Contributor

aehanno commented May 13, 2022

Adding code to activate translation in DatePicker component
@aehanno aehanno added the #bug Bug report label May 13, 2022
@aehanno aehanno closed this as completed May 13, 2022
@aehanno aehanno reopened this May 13, 2022
@aehanno aehanno mentioned this issue May 13, 2022
Merged
@zhaoyongjie
Copy link
Member

@aehanno Thanks for the contribution. I left a comment on you PR.

@aehanno
Copy link
Contributor Author

aehanno commented May 27, 2022

@aehanno Thanks for the contribution. I left a comment on you PR.

Hi @zhaoyongjie, I did some change to add a mapping, let me know if it's correct for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
#bug Bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add locale for DatePicker component kosmos-education/superset
2 participants
@zhaoyongjie @aehanno