Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German Translation not correctly implemented? #19431

Closed
2 tasks done
CFM90 opened this issue Mar 30, 2022 · 2 comments
Closed
2 tasks done

German Translation not correctly implemented? #19431

CFM90 opened this issue Mar 30, 2022 · 2 comments
Labels
#bug Bug report i18n:german Translation related to German language

Comments

@CFM90
Copy link

CFM90 commented Mar 30, 2022

The German translation is very much incomplete. But I suspect a bug not an incomplete tanslation per se, because as the screnshots by @hbruch in PR17525 indicate, the German translation is way more complete compared what I can find on a fresh install. So there may be a good German translation which is not correctly included in superset itself. This would be a pitty for all German users and the creator of the translation.

How to reproduce the bug

  1. Install Superset from Scratch following this. (so not using docker)
  2. Add the following to the superset_config:
BABEL_DEFAULT_LOCALE = "de"
BABEL_DEFAULT_FOLDER = "superset/translations"

LANGUAGES = {
    'en': {'flag': 'us', 'name': 'English'},
    'de': {'flag': 'de', 'name': 'German'}
}

Expected results

A German translation similar to those visible on the screenshots by @hbruch in:
PR17525

Actual results & Screenshots

grafik

grafik

grafik

You can see that there are terms which are translated to German and others which are not. The overall impression is very incomplete and incomprehensive.

Environment

  • browser type and version: Mozilla Firefox V 98.02
  • superset version: 1.4.2, the most recent one
  • python version: 3.8.10
  • node.js version: v10.19.0
  • any feature flags active:
FEATURE_FLAGS = {
  "DASHBOARD_CACHE": True,
  "ALERT_REPORTS": True,
  "DASHBOARD_RBAC": True,  
  "LISTVIEWS_DEFAULT_CARD_VIEW" : True,
  "ENABLE_EXPLORE_DRAG_AND_DROP": True,
  "OMNIBAR" : True,
  "CLIENT_CACHE": True
}

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional Information

I also worked on a translation (because I thought the existing one is just incomplete). I was able to translate more words and terms using the .mo files as seen on the screenshots here from the fresh install. So the translation from the fresh install is not incomplete because the englisch words are not included in the babel process.

@CFM90 CFM90 added the #bug Bug report label Mar 30, 2022
@srinify srinify added the i18n:german Translation related to German language label Mar 30, 2022
@rusackas
Copy link
Member

I think this is not a bug, per se, but rather a piece of technical debt that needs to be worked on. The configuration itself even admits this:

# Turning off i18n by default as translation in most languages are
# incomplete and not well maintained.

I'll close this since it's been open for upward of a year and hasn't gotten any attention. Suffice it to say that we would LOVE to see some PRs in this area, and incrementally make the situation better for German and other languages as well. If you'd like assistance, please reach out.

Thanks!

@rusackas rusackas closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2023
@hbruch
Copy link
Contributor

hbruch commented Apr 7, 2023

With #23402 merged just now, a next bunch of German translations has been added. Helas, it did not make it into the 2.1.0 release, so you would need to build it from master.

There will still be some messages which are not localized, as i18n is still to be done. See #21479

Note: the .po files need to be compiled, e.g. using pybabel compile -d superset/translations. When using docker, this is already be taken care of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report i18n:german Translation related to German language
Projects
None yet
Development

No branches or pull requests

4 participants