This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Migrate components to TypeScript #18100
Labels
enhancement:request
Enhancement request submitted by anyone from the community
good first issue
Good first issues for new contributors
Comments
This was referenced Jan 20, 2022
ad-m
added a commit
to ad-m/superset
that referenced
this issue
Jan 20, 2022
kgabryje
pushed a commit
that referenced
this issue
Jan 20, 2022
|
Working on following components:
|
9 tasks
|
@kgabryje @michael-s-molina Can I ask for "good first issue" label? |
9 tasks
9 tasks
jayakrishnankk
pushed a commit
to jayakrishnankk/superset
that referenced
this issue
Jan 21, 2022
9 tasks
9 tasks
This was referenced Jan 23, 2022
zhaoyongjie
pushed a commit
that referenced
this issue
Jan 24, 2022
9 tasks
geido
added
the
enhancement:request
|
Hey @ad-m this is great! Thanks for providing this list!! |
|
How does this list differ from the one in #10004 ? |
srinify
added a commit
that referenced
this issue
Jan 25, 2022
* fix: handle null values in time-series table (#18039) * cleanup column_type_mappings (#17569) Signed-off-by: Đặng Minh Dũng <dungdm93@live.com> * important change to MakeFile (#18037) * Update superset-e2e.yml (#18041) * Revert "Update superset-e2e.yml (#18041)" (#18051) This reverts commit b565273. * feat: Trino Authentications (#17593) * feat: support Trino Authentications Signed-off-by: Đặng Minh Dũng <dungdm93@live.com> * docs: Trino Authentications Signed-off-by: Đặng Minh Dũng <dungdm93@live.com> * chore(supeset.utils.core): move all database utils to database utils module (#18058) * chore(plugin-chart-echarts): add types to controls (#18059) * fix(generator): more cleanup to plugin framework (#18027) * fix(generator): more cleanup to plugin framework * fix typo and package name * add docs * fix typo * Update superset-frontend/webpack.config.js Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> * fix generator reference * add steps to tutorial and fix package version * refine docs/readme Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> * feat(advanced analytics): support groupby in resample (#18045) * fix(dashboard): scope of nativefilter not update (#18048) * fix(generator): add lockfile and fix styling issues (#18073) * fix(generator): add lockfile and fix styling issues * fix margins and remove redundant scroll * update tutorial * refactor(sql_lab): SQL Lab Persistent Saved State (#17771) * a lot of console logs * testing * test * added saved_query to remoteId * created useEffect so that title properly changes in modal * Update superset-frontend/src/SqlLab/actions/sqlLab.js Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> * refactor(example_data): replace the way the birth_names data is loaded to DB (#18060) * refactor: replace the way the birth_names data is loaded to DB * fix failed unit test * fix failed unit test * fix failed tests * fix pass wrong flag of support datetime type * remove unused fixture * feat: add chart description in info tooltip (#17207) * feat: add chart list description * fix: text overflow * fix: text-overflow with line-height * Correction of proper names format in README (#18087) * chore: added SEO routes * fix can't use examples helpers on non app context based environment (#18086) * chore: split CLI into multiple files (#18082) * chore: split CLI into multiple files * Update tests * Who fixes the fixtures? * Add subcommands dynamically * Rebase * fix misspelling (#18097) * refactor: sqleditorleftbar to functional (#17807) * Working on converting sqleditorleftbar to functional component * Creating draft PR to address bug * Still working on solving re rendering bug * infinite rerender fix * Creating draft PR to address bug * Cleaning up in preparation for push * Made changes suggested by Elizabeth * Fixed issues as per Lindsey's comment Co-authored-by: Arash <arash.afghahi@gmail.com> * fix rat excludes and headers * fix(docs): fix path of image for "Create New Chart" (#18089) * Migrate Checkbox story to tsx - see #18100 (#18101) Looks good! * refactor: migrate RowCountLabel to TypeScript & added story (#18105) * enable superbook for explore component * migrate RowCountLabel to TypeScript * add storybook for RowCountLabel * fix: logging warning on dataframe (don't use python's warnings) (#18111) * fix: logging warning on dataframe (don't use python's warnings) * lint * update changelog and updating for 1.4.0 (#18083) * feat: Adds a key-value endpoint to store charts form data (#17882) * feat: Adds a key-value endpoint to store charts form data * Fixes linting problems * Removes the query_params from the endpoints * Refactors the commands * Removes unused imports * Changes the parameters to use dataclass * Adds more access tests * Gets the first dataset while testing * Adds unit tests for the check_access function * Changes the can_access check * Always check for dataset access * fix(explore): fix chart embed code modal glitch (#17843) * feat(plugin-chart-echarts): support non-timeseries x-axis (#17917) * feat(plugin-chart-echarts): support non-timeseries x-axis * fix tests * change formula return type from Date to number * add x_axis test coverage * rename func and improve coverage * add x-axis control to bar chart * remove redundant console.log * fix description * make x-axis control mandatory * 🙃 * fix x-axis formatter * fix showValues * fix implicit rDTTM_ALIAS references in postProcessing * replace TIME_COLUMN with DTTM_ALIAS * fix remaining implicit indexes * fix: Disable filtering on wide result sets (#18021) * fix: handle null values in time-series table (#18039) * cleanup column_type_mappings (#17569) Signed-off-by: Đặng Minh Dũng <dungdm93@live.com> * important change to MakeFile (#18037) * add missing is_timeseries to pivot op Co-authored-by: Erik Ritter <erik.ritter@airbnb.com> Co-authored-by: Grace Guo <grace.guo@airbnb.com> Co-authored-by: Đặng Minh Dũng <dungdm93@live.com> Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> * feat(country-map): added new countries in country-chart-map (#18081) * chore: migrating storybook jsx to typescript #18100 (#18133) * Migrating storybook jsx to typescript #18100 * Migrating storybook jsx to typescript Co-authored-by: Jayakrishnan Karolil <jayakrishnan.karolil@nielsen.com> * feat(annotation): add toast feedback to annotation templates (#18116) * feat(dashboard): add toast feedback to dashboard actions (#18114) * feat(explore): more toast feedback on user actions in Explore (#18108) * feat(explore): add toasts feedback when user copies chart url * Show toast message when updating chart properties * Change toast type to success when saving chart * Use success toast from props * Fix tests * Use withToasts instead of dispatch * Use PropertiesModalProps instead of any * Docs: fix typo (#18125) * fix: undefined error when adding extra sequential color scheme (#18152) * feat: allow assets to be managed externally (#18093) * feat: allow assets to be managed externally * Use server_default * chore: use pkg_resources for cleaner config (#18130) * refactor: Moves the Explore form_data endpoint (#18151) * refactor: Moves the Explore form_data endpoint * Removes unused imports * Fixes openapi schema error * Fixes typo * Renames and UPDATING.md Co-authored-by: Grace Guo <grace.guo@airbnb.com> Co-authored-by: Đặng Minh Dũng <dungdm93@live.com> Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com> Co-authored-by: ofekisr <35701650+ofekisr@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com> Co-authored-by: Stephen Liu <750188453@qq.com> Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: Adam Dobrawy <ad-m@users.noreply.github.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Emily Wu <86927881+em0227@users.noreply.github.com> Co-authored-by: Josue Lugaro <82119536+JosueLugaro@users.noreply.github.com> Co-authored-by: Arash <arash.afghahi@gmail.com> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Erik Ritter <erik.ritter@airbnb.com> Co-authored-by: Hammad-Raza <hammadraza42@hotmail.com> Co-authored-by: jayakrishnankk <kk.jayakrishnan@gmail.com> Co-authored-by: Jayakrishnan Karolil <jayakrishnan.karolil@nielsen.com> Co-authored-by: Farid Rener <proteusvacuum@users.noreply.github.com>
9 tasks
This was referenced Jan 27, 2022
hughhhh
added a commit
that referenced
this issue
Jan 27, 2022
* setup docusaurus * rename * add introduction content * chore(docsV2): move content from docs to docsV2 (#17714) * add FAQs and contribution pages * chore: add api, security, and roadmap pages, include swaggerui in dependency for api page * chore: move api page header below imports * chore: change API page info alert to use built in Infima class instead of custom class Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local> * chore(docs-v2): moving more markdown content to new documentation site (#17736) * chore: move markdown content and images for docs installation directory to docs-v2 * chore: move docs miscellaneous directory content to docs-v2 * chore(docs-v2): move over connecting to databases content and rename some files to .mdx Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local> * Update styling and logo (#17990) * update styling * update colors * chore(docs-v2): remove blog and tutorial and update some styling (#17929) * add superset logo and favicon, change styles to better match current docs, add prettierrc * change file types to mdx * Add simple superset dark mode freindly logo * clean up default pages - blog and tutorial docs Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local> * Chore: moving charts and dashboard to docusaurus (#18036) * add contributing add creating charts and dashboards * delete extra images * update rat-excludes * Port homepage (#18115) * Port community page (#18128) * chore: add seo redirects for Docs v@ (#18092) * fix: handle null values in time-series table (#18039) * cleanup column_type_mappings (#17569) Signed-off-by: Đặng Minh Dũng <dungdm93@live.com> * important change to MakeFile (#18037) * Update superset-e2e.yml (#18041) * Revert "Update superset-e2e.yml (#18041)" (#18051) This reverts commit b565273. * feat: Trino Authentications (#17593) * feat: support Trino Authentications Signed-off-by: Đặng Minh Dũng <dungdm93@live.com> * docs: Trino Authentications Signed-off-by: Đặng Minh Dũng <dungdm93@live.com> * chore(supeset.utils.core): move all database utils to database utils module (#18058) * chore(plugin-chart-echarts): add types to controls (#18059) * fix(generator): more cleanup to plugin framework (#18027) * fix(generator): more cleanup to plugin framework * fix typo and package name * add docs * fix typo * Update superset-frontend/webpack.config.js Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> * fix generator reference * add steps to tutorial and fix package version * refine docs/readme Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> * feat(advanced analytics): support groupby in resample (#18045) * fix(dashboard): scope of nativefilter not update (#18048) * fix(generator): add lockfile and fix styling issues (#18073) * fix(generator): add lockfile and fix styling issues * fix margins and remove redundant scroll * update tutorial * refactor(sql_lab): SQL Lab Persistent Saved State (#17771) * a lot of console logs * testing * test * added saved_query to remoteId * created useEffect so that title properly changes in modal * Update superset-frontend/src/SqlLab/actions/sqlLab.js Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> * refactor(example_data): replace the way the birth_names data is loaded to DB (#18060) * refactor: replace the way the birth_names data is loaded to DB * fix failed unit test * fix failed unit test * fix failed tests * fix pass wrong flag of support datetime type * remove unused fixture * feat: add chart description in info tooltip (#17207) * feat: add chart list description * fix: text overflow * fix: text-overflow with line-height * Correction of proper names format in README (#18087) * chore: added SEO routes * fix can't use examples helpers on non app context based environment (#18086) * chore: split CLI into multiple files (#18082) * chore: split CLI into multiple files * Update tests * Who fixes the fixtures? * Add subcommands dynamically * Rebase * fix misspelling (#18097) * refactor: sqleditorleftbar to functional (#17807) * Working on converting sqleditorleftbar to functional component * Creating draft PR to address bug * Still working on solving re rendering bug * infinite rerender fix * Creating draft PR to address bug * Cleaning up in preparation for push * Made changes suggested by Elizabeth * Fixed issues as per Lindsey's comment Co-authored-by: Arash <arash.afghahi@gmail.com> * fix rat excludes and headers * fix(docs): fix path of image for "Create New Chart" (#18089) * Migrate Checkbox story to tsx - see #18100 (#18101) Looks good! * refactor: migrate RowCountLabel to TypeScript & added story (#18105) * enable superbook for explore component * migrate RowCountLabel to TypeScript * add storybook for RowCountLabel * fix: logging warning on dataframe (don't use python's warnings) (#18111) * fix: logging warning on dataframe (don't use python's warnings) * lint * update changelog and updating for 1.4.0 (#18083) * feat: Adds a key-value endpoint to store charts form data (#17882) * feat: Adds a key-value endpoint to store charts form data * Fixes linting problems * Removes the query_params from the endpoints * Refactors the commands * Removes unused imports * Changes the parameters to use dataclass * Adds more access tests * Gets the first dataset while testing * Adds unit tests for the check_access function * Changes the can_access check * Always check for dataset access * fix(explore): fix chart embed code modal glitch (#17843) * feat(plugin-chart-echarts): support non-timeseries x-axis (#17917) * feat(plugin-chart-echarts): support non-timeseries x-axis * fix tests * change formula return type from Date to number * add x_axis test coverage * rename func and improve coverage * add x-axis control to bar chart * remove redundant console.log * fix description * make x-axis control mandatory * 🙃 * fix x-axis formatter * fix showValues * fix implicit rDTTM_ALIAS references in postProcessing * replace TIME_COLUMN with DTTM_ALIAS * fix remaining implicit indexes * fix: Disable filtering on wide result sets (#18021) * fix: handle null values in time-series table (#18039) * cleanup column_type_mappings (#17569) Signed-off-by: Đặng Minh Dũng <dungdm93@live.com> * important change to MakeFile (#18037) * add missing is_timeseries to pivot op Co-authored-by: Erik Ritter <erik.ritter@airbnb.com> Co-authored-by: Grace Guo <grace.guo@airbnb.com> Co-authored-by: Đặng Minh Dũng <dungdm93@live.com> Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> * feat(country-map): added new countries in country-chart-map (#18081) * chore: migrating storybook jsx to typescript #18100 (#18133) * Migrating storybook jsx to typescript #18100 * Migrating storybook jsx to typescript Co-authored-by: Jayakrishnan Karolil <jayakrishnan.karolil@nielsen.com> * feat(annotation): add toast feedback to annotation templates (#18116) * feat(dashboard): add toast feedback to dashboard actions (#18114) * feat(explore): more toast feedback on user actions in Explore (#18108) * feat(explore): add toasts feedback when user copies chart url * Show toast message when updating chart properties * Change toast type to success when saving chart * Use success toast from props * Fix tests * Use withToasts instead of dispatch * Use PropertiesModalProps instead of any * Docs: fix typo (#18125) * fix: undefined error when adding extra sequential color scheme (#18152) * feat: allow assets to be managed externally (#18093) * feat: allow assets to be managed externally * Use server_default * chore: use pkg_resources for cleaner config (#18130) * refactor: Moves the Explore form_data endpoint (#18151) * refactor: Moves the Explore form_data endpoint * Removes unused imports * Fixes openapi schema error * Fixes typo * Renames and UPDATING.md Co-authored-by: Grace Guo <grace.guo@airbnb.com> Co-authored-by: Đặng Minh Dũng <dungdm93@live.com> Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com> Co-authored-by: ofekisr <35701650+ofekisr@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com> Co-authored-by: Stephen Liu <750188453@qq.com> Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: Adam Dobrawy <ad-m@users.noreply.github.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Emily Wu <86927881+em0227@users.noreply.github.com> Co-authored-by: Josue Lugaro <82119536+JosueLugaro@users.noreply.github.com> Co-authored-by: Arash <arash.afghahi@gmail.com> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Erik Ritter <erik.ritter@airbnb.com> Co-authored-by: Hammad-Raza <hammadraza42@hotmail.com> Co-authored-by: jayakrishnankk <kk.jayakrishnan@gmail.com> Co-authored-by: Jayakrishnan Karolil <jayakrishnan.karolil@nielsen.com> Co-authored-by: Farid Rener <proteusvacuum@users.noreply.github.com> * remove unneeded requirement Co-authored-by: Corbin Robb <31329271+corbinrobb@users.noreply.github.com> Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local> Co-authored-by: Daniel W <61300812+The-hyphen-user@users.noreply.github.com> Co-authored-by: Geido <60598000+geido@users.noreply.github.com> Co-authored-by: Srini Kadamati <skadamat@gmail.com> Co-authored-by: Grace Guo <grace.guo@airbnb.com> Co-authored-by: Đặng Minh Dũng <dungdm93@live.com> Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: ofekisr <35701650+ofekisr@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com> Co-authored-by: Stephen Liu <750188453@qq.com> Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: Adam Dobrawy <ad-m@users.noreply.github.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Emily Wu <86927881+em0227@users.noreply.github.com> Co-authored-by: Josue Lugaro <82119536+JosueLugaro@users.noreply.github.com> Co-authored-by: Arash <arash.afghahi@gmail.com> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Erik Ritter <erik.ritter@airbnb.com> Co-authored-by: Hammad-Raza <hammadraza42@hotmail.com> Co-authored-by: jayakrishnankk <kk.jayakrishnan@gmail.com> Co-authored-by: Jayakrishnan Karolil <jayakrishnan.karolil@nielsen.com> Co-authored-by: Farid Rener <proteusvacuum@users.noreply.github.com>
srinify
added a commit
that referenced
this issue
Jan 28, 2022
* setup docusaurus * rename * add introduction content * chore(docsV2): move content from docs to docsV2 (#17714) * add FAQs and contribution pages * chore: add api, security, and roadmap pages, include swaggerui in dependency for api page * chore: move api page header below imports * chore: change API page info alert to use built in Infima class instead of custom class Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local> * chore(docs-v2): moving more markdown content to new documentation site (#17736) * chore: move markdown content and images for docs installation directory to docs-v2 * chore: move docs miscellaneous directory content to docs-v2 * chore(docs-v2): move over connecting to databases content and rename some files to .mdx Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local> * Update styling and logo (#17990) * update styling * update colors * chore(docs-v2): remove blog and tutorial and update some styling (#17929) * add superset logo and favicon, change styles to better match current docs, add prettierrc * change file types to mdx * Add simple superset dark mode freindly logo * clean up default pages - blog and tutorial docs Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local> * Chore: moving charts and dashboard to docusaurus (#18036) * add contributing add creating charts and dashboards * delete extra images * update rat-excludes * Port homepage (#18115) * Port community page (#18128) * chore: add seo redirects for Docs v@ (#18092) * fix: handle null values in time-series table (#18039) * cleanup column_type_mappings (#17569) Signed-off-by: Đặng Minh Dũng <dungdm93@live.com> * important change to MakeFile (#18037) * Update superset-e2e.yml (#18041) * Revert "Update superset-e2e.yml (#18041)" (#18051) This reverts commit b565273. * feat: Trino Authentications (#17593) * feat: support Trino Authentications Signed-off-by: Đặng Minh Dũng <dungdm93@live.com> * docs: Trino Authentications Signed-off-by: Đặng Minh Dũng <dungdm93@live.com> * chore(supeset.utils.core): move all database utils to database utils module (#18058) * chore(plugin-chart-echarts): add types to controls (#18059) * fix(generator): more cleanup to plugin framework (#18027) * fix(generator): more cleanup to plugin framework * fix typo and package name * add docs * fix typo * Update superset-frontend/webpack.config.js Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> * fix generator reference * add steps to tutorial and fix package version * refine docs/readme Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> * feat(advanced analytics): support groupby in resample (#18045) * fix(dashboard): scope of nativefilter not update (#18048) * fix(generator): add lockfile and fix styling issues (#18073) * fix(generator): add lockfile and fix styling issues * fix margins and remove redundant scroll * update tutorial * refactor(sql_lab): SQL Lab Persistent Saved State (#17771) * a lot of console logs * testing * test * added saved_query to remoteId * created useEffect so that title properly changes in modal * Update superset-frontend/src/SqlLab/actions/sqlLab.js Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> * refactor(example_data): replace the way the birth_names data is loaded to DB (#18060) * refactor: replace the way the birth_names data is loaded to DB * fix failed unit test * fix failed unit test * fix failed tests * fix pass wrong flag of support datetime type * remove unused fixture * feat: add chart description in info tooltip (#17207) * feat: add chart list description * fix: text overflow * fix: text-overflow with line-height * Correction of proper names format in README (#18087) * chore: added SEO routes * fix can't use examples helpers on non app context based environment (#18086) * chore: split CLI into multiple files (#18082) * chore: split CLI into multiple files * Update tests * Who fixes the fixtures? * Add subcommands dynamically * Rebase * fix misspelling (#18097) * refactor: sqleditorleftbar to functional (#17807) * Working on converting sqleditorleftbar to functional component * Creating draft PR to address bug * Still working on solving re rendering bug * infinite rerender fix * Creating draft PR to address bug * Cleaning up in preparation for push * Made changes suggested by Elizabeth * Fixed issues as per Lindsey's comment Co-authored-by: Arash <arash.afghahi@gmail.com> * fix rat excludes and headers * fix(docs): fix path of image for "Create New Chart" (#18089) * Migrate Checkbox story to tsx - see #18100 (#18101) Looks good! * refactor: migrate RowCountLabel to TypeScript & added story (#18105) * enable superbook for explore component * migrate RowCountLabel to TypeScript * add storybook for RowCountLabel * fix: logging warning on dataframe (don't use python's warnings) (#18111) * fix: logging warning on dataframe (don't use python's warnings) * lint * update changelog and updating for 1.4.0 (#18083) * feat: Adds a key-value endpoint to store charts form data (#17882) * feat: Adds a key-value endpoint to store charts form data * Fixes linting problems * Removes the query_params from the endpoints * Refactors the commands * Removes unused imports * Changes the parameters to use dataclass * Adds more access tests * Gets the first dataset while testing * Adds unit tests for the check_access function * Changes the can_access check * Always check for dataset access * fix(explore): fix chart embed code modal glitch (#17843) * feat(plugin-chart-echarts): support non-timeseries x-axis (#17917) * feat(plugin-chart-echarts): support non-timeseries x-axis * fix tests * change formula return type from Date to number * add x_axis test coverage * rename func and improve coverage * add x-axis control to bar chart * remove redundant console.log * fix description * make x-axis control mandatory * 🙃 * fix x-axis formatter * fix showValues * fix implicit rDTTM_ALIAS references in postProcessing * replace TIME_COLUMN with DTTM_ALIAS * fix remaining implicit indexes * fix: Disable filtering on wide result sets (#18021) * fix: handle null values in time-series table (#18039) * cleanup column_type_mappings (#17569) Signed-off-by: Đặng Minh Dũng <dungdm93@live.com> * important change to MakeFile (#18037) * add missing is_timeseries to pivot op Co-authored-by: Erik Ritter <erik.ritter@airbnb.com> Co-authored-by: Grace Guo <grace.guo@airbnb.com> Co-authored-by: Đặng Minh Dũng <dungdm93@live.com> Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> * feat(country-map): added new countries in country-chart-map (#18081) * chore: migrating storybook jsx to typescript #18100 (#18133) * Migrating storybook jsx to typescript #18100 * Migrating storybook jsx to typescript Co-authored-by: Jayakrishnan Karolil <jayakrishnan.karolil@nielsen.com> * feat(annotation): add toast feedback to annotation templates (#18116) * feat(dashboard): add toast feedback to dashboard actions (#18114) * feat(explore): more toast feedback on user actions in Explore (#18108) * feat(explore): add toasts feedback when user copies chart url * Show toast message when updating chart properties * Change toast type to success when saving chart * Use success toast from props * Fix tests * Use withToasts instead of dispatch * Use PropertiesModalProps instead of any * Docs: fix typo (#18125) * fix: undefined error when adding extra sequential color scheme (#18152) * feat: allow assets to be managed externally (#18093) * feat: allow assets to be managed externally * Use server_default * chore: use pkg_resources for cleaner config (#18130) * refactor: Moves the Explore form_data endpoint (#18151) * refactor: Moves the Explore form_data endpoint * Removes unused imports * Fixes openapi schema error * Fixes typo * Renames and UPDATING.md Co-authored-by: Grace Guo <grace.guo@airbnb.com> Co-authored-by: Đặng Minh Dũng <dungdm93@live.com> Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com> Co-authored-by: ofekisr <35701650+ofekisr@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com> Co-authored-by: Stephen Liu <750188453@qq.com> Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: Adam Dobrawy <ad-m@users.noreply.github.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Emily Wu <86927881+em0227@users.noreply.github.com> Co-authored-by: Josue Lugaro <82119536+JosueLugaro@users.noreply.github.com> Co-authored-by: Arash <arash.afghahi@gmail.com> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Erik Ritter <erik.ritter@airbnb.com> Co-authored-by: Hammad-Raza <hammadraza42@hotmail.com> Co-authored-by: jayakrishnankk <kk.jayakrishnan@gmail.com> Co-authored-by: Jayakrishnan Karolil <jayakrishnan.karolil@nielsen.com> Co-authored-by: Farid Rener <proteusvacuum@users.noreply.github.com> * fix up links * Fix whitespace * Remove unwanted change * Add apache links Co-authored-by: hughhhh <hughmil3s@gmail.com> Co-authored-by: Corbin Robb <31329271+corbinrobb@users.noreply.github.com> Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local> Co-authored-by: Daniel W <61300812+The-hyphen-user@users.noreply.github.com> Co-authored-by: Srini Kadamati <skadamat@gmail.com> Co-authored-by: Grace Guo <grace.guo@airbnb.com> Co-authored-by: Đặng Minh Dũng <dungdm93@live.com> Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: ofekisr <35701650+ofekisr@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com> Co-authored-by: Stephen Liu <750188453@qq.com> Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: Adam Dobrawy <ad-m@users.noreply.github.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Emily Wu <86927881+em0227@users.noreply.github.com> Co-authored-by: Josue Lugaro <82119536+JosueLugaro@users.noreply.github.com> Co-authored-by: Arash <arash.afghahi@gmail.com> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Erik Ritter <erik.ritter@airbnb.com> Co-authored-by: Hammad-Raza <hammadraza42@hotmail.com> Co-authored-by: jayakrishnankk <kk.jayakrishnan@gmail.com> Co-authored-by: Jayakrishnan Karolil <jayakrishnan.karolil@nielsen.com> Co-authored-by: Farid Rener <proteusvacuum@users.noreply.github.com>
geido
added a commit
that referenced
this issue
Jan 31, 2022
* setup docusaurus * rename * add introduction content * chore(docsV2): move content from docs to docsV2 (#17714) * add FAQs and contribution pages * chore: add api, security, and roadmap pages, include swaggerui in dependency for api page * chore: move api page header below imports * chore: change API page info alert to use built in Infima class instead of custom class Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local> * chore(docs-v2): moving more markdown content to new documentation site (#17736) * chore: move markdown content and images for docs installation directory to docs-v2 * chore: move docs miscellaneous directory content to docs-v2 * chore(docs-v2): move over connecting to databases content and rename some files to .mdx Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local> * Update styling and logo (#17990) * update styling * update colors * chore(docs-v2): remove blog and tutorial and update some styling (#17929) * add superset logo and favicon, change styles to better match current docs, add prettierrc * change file types to mdx * Add simple superset dark mode freindly logo * clean up default pages - blog and tutorial docs Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local> * Chore: moving charts and dashboard to docusaurus (#18036) * add contributing add creating charts and dashboards * delete extra images * update rat-excludes * Port homepage (#18115) * Port community page (#18128) * chore: add seo redirects for Docs v@ (#18092) * fix: handle null values in time-series table (#18039) * cleanup column_type_mappings (#17569) Signed-off-by: Đặng Minh Dũng <dungdm93@live.com> * important change to MakeFile (#18037) * Update superset-e2e.yml (#18041) * Revert "Update superset-e2e.yml (#18041)" (#18051) This reverts commit b565273. * feat: Trino Authentications (#17593) * feat: support Trino Authentications Signed-off-by: Đặng Minh Dũng <dungdm93@live.com> * docs: Trino Authentications Signed-off-by: Đặng Minh Dũng <dungdm93@live.com> * chore(supeset.utils.core): move all database utils to database utils module (#18058) * chore(plugin-chart-echarts): add types to controls (#18059) * fix(generator): more cleanup to plugin framework (#18027) * fix(generator): more cleanup to plugin framework * fix typo and package name * add docs * fix typo * Update superset-frontend/webpack.config.js Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> * fix generator reference * add steps to tutorial and fix package version * refine docs/readme Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> * feat(advanced analytics): support groupby in resample (#18045) * fix(dashboard): scope of nativefilter not update (#18048) * fix(generator): add lockfile and fix styling issues (#18073) * fix(generator): add lockfile and fix styling issues * fix margins and remove redundant scroll * update tutorial * refactor(sql_lab): SQL Lab Persistent Saved State (#17771) * a lot of console logs * testing * test * added saved_query to remoteId * created useEffect so that title properly changes in modal * Update superset-frontend/src/SqlLab/actions/sqlLab.js Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> * refactor(example_data): replace the way the birth_names data is loaded to DB (#18060) * refactor: replace the way the birth_names data is loaded to DB * fix failed unit test * fix failed unit test * fix failed tests * fix pass wrong flag of support datetime type * remove unused fixture * feat: add chart description in info tooltip (#17207) * feat: add chart list description * fix: text overflow * fix: text-overflow with line-height * Correction of proper names format in README (#18087) * chore: added SEO routes * fix can't use examples helpers on non app context based environment (#18086) * chore: split CLI into multiple files (#18082) * chore: split CLI into multiple files * Update tests * Who fixes the fixtures? * Add subcommands dynamically * Rebase * fix misspelling (#18097) * refactor: sqleditorleftbar to functional (#17807) * Working on converting sqleditorleftbar to functional component * Creating draft PR to address bug * Still working on solving re rendering bug * infinite rerender fix * Creating draft PR to address bug * Cleaning up in preparation for push * Made changes suggested by Elizabeth * Fixed issues as per Lindsey's comment Co-authored-by: Arash <arash.afghahi@gmail.com> * fix rat excludes and headers * fix(docs): fix path of image for "Create New Chart" (#18089) * Migrate Checkbox story to tsx - see #18100 (#18101) Looks good! * refactor: migrate RowCountLabel to TypeScript & added story (#18105) * enable superbook for explore component * migrate RowCountLabel to TypeScript * add storybook for RowCountLabel * fix: logging warning on dataframe (don't use python's warnings) (#18111) * fix: logging warning on dataframe (don't use python's warnings) * lint * update changelog and updating for 1.4.0 (#18083) * feat: Adds a key-value endpoint to store charts form data (#17882) * feat: Adds a key-value endpoint to store charts form data * Fixes linting problems * Removes the query_params from the endpoints * Refactors the commands * Removes unused imports * Changes the parameters to use dataclass * Adds more access tests * Gets the first dataset while testing * Adds unit tests for the check_access function * Changes the can_access check * Always check for dataset access * fix(explore): fix chart embed code modal glitch (#17843) * feat(plugin-chart-echarts): support non-timeseries x-axis (#17917) * feat(plugin-chart-echarts): support non-timeseries x-axis * fix tests * change formula return type from Date to number * add x_axis test coverage * rename func and improve coverage * add x-axis control to bar chart * remove redundant console.log * fix description * make x-axis control mandatory * 🙃 * fix x-axis formatter * fix showValues * fix implicit rDTTM_ALIAS references in postProcessing * replace TIME_COLUMN with DTTM_ALIAS * fix remaining implicit indexes * fix: Disable filtering on wide result sets (#18021) * fix: handle null values in time-series table (#18039) * cleanup column_type_mappings (#17569) Signed-off-by: Đặng Minh Dũng <dungdm93@live.com> * important change to MakeFile (#18037) * add missing is_timeseries to pivot op Co-authored-by: Erik Ritter <erik.ritter@airbnb.com> Co-authored-by: Grace Guo <grace.guo@airbnb.com> Co-authored-by: Đặng Minh Dũng <dungdm93@live.com> Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> * feat(country-map): added new countries in country-chart-map (#18081) * chore: migrating storybook jsx to typescript #18100 (#18133) * Migrating storybook jsx to typescript #18100 * Migrating storybook jsx to typescript Co-authored-by: Jayakrishnan Karolil <jayakrishnan.karolil@nielsen.com> * feat(annotation): add toast feedback to annotation templates (#18116) * feat(dashboard): add toast feedback to dashboard actions (#18114) * feat(explore): more toast feedback on user actions in Explore (#18108) * feat(explore): add toasts feedback when user copies chart url * Show toast message when updating chart properties * Change toast type to success when saving chart * Use success toast from props * Fix tests * Use withToasts instead of dispatch * Use PropertiesModalProps instead of any * Docs: fix typo (#18125) * fix: undefined error when adding extra sequential color scheme (#18152) * feat: allow assets to be managed externally (#18093) * feat: allow assets to be managed externally * Use server_default * chore: use pkg_resources for cleaner config (#18130) * refactor: Moves the Explore form_data endpoint (#18151) * refactor: Moves the Explore form_data endpoint * Removes unused imports * Fixes openapi schema error * Fixes typo * Renames and UPDATING.md Co-authored-by: Grace Guo <grace.guo@airbnb.com> Co-authored-by: Đặng Minh Dũng <dungdm93@live.com> Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com> Co-authored-by: ofekisr <35701650+ofekisr@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com> Co-authored-by: Stephen Liu <750188453@qq.com> Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: Adam Dobrawy <ad-m@users.noreply.github.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Emily Wu <86927881+em0227@users.noreply.github.com> Co-authored-by: Josue Lugaro <82119536+JosueLugaro@users.noreply.github.com> Co-authored-by: Arash <arash.afghahi@gmail.com> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Erik Ritter <erik.ritter@airbnb.com> Co-authored-by: Hammad-Raza <hammadraza42@hotmail.com> Co-authored-by: jayakrishnankk <kk.jayakrishnan@gmail.com> Co-authored-by: Jayakrishnan Karolil <jayakrishnan.karolil@nielsen.com> Co-authored-by: Farid Rener <proteusvacuum@users.noreply.github.com> * Fix broken build * Revert unwanted change Co-authored-by: hughhhh <hughmil3s@gmail.com> Co-authored-by: Corbin Robb <31329271+corbinrobb@users.noreply.github.com> Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local> Co-authored-by: Daniel W <61300812+The-hyphen-user@users.noreply.github.com> Co-authored-by: Srini Kadamati <skadamat@gmail.com> Co-authored-by: Grace Guo <grace.guo@airbnb.com> Co-authored-by: Đặng Minh Dũng <dungdm93@live.com> Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: ofekisr <35701650+ofekisr@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com> Co-authored-by: Stephen Liu <750188453@qq.com> Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: Adam Dobrawy <ad-m@users.noreply.github.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Emily Wu <86927881+em0227@users.noreply.github.com> Co-authored-by: Josue Lugaro <82119536+JosueLugaro@users.noreply.github.com> Co-authored-by: Arash <arash.afghahi@gmail.com> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Erik Ritter <erik.ritter@airbnb.com> Co-authored-by: Hammad-Raza <hammadraza42@hotmail.com> Co-authored-by: jayakrishnankk <kk.jayakrishnan@gmail.com> Co-authored-by: Jayakrishnan Karolil <jayakrishnan.karolil@nielsen.com> Co-authored-by: Farid Rener <proteusvacuum@users.noreply.github.com>
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Is your feature request related to a problem? Please describe.
Since SIP-9 in 2018, TypeScript has been a part of the Superset repo. Since SIP-36 in 2020 all new frontend code should be written in TypeScript. When modifying old functions/components, migrating to TypeScript is appreciated, but not required.
We have still a bit non-TypeScript components on frontend:
Describe the solution you'd like
We should rewrite frontend components to use JSX. I listed all of them to track progress.
superset-frontend/src/visualizations/TimeTable/TimeTable.jsxsuperset-frontend/src/visualizations/FilterBox/controlPanel.jsxsuperset-frontend/src/visualizations/FilterBox/FilterBox.test.jsxsuperset-frontend/src/visualizations/FilterBox/FilterBox.jsxsuperset-frontend/src/modules/utils.test.jsxsuperset-frontend/src/explore/exploreUtils/exploreUtils.test.jsxsuperset-frontend/src/explore/index.jsxsuperset-frontend/src/explore/store.test.jsxsuperset-frontend/src/explore/controls.jsxsuperset-frontend/src/explore/App.jsxsuperset-frontend/src/explore/components/ExploreAdditionalActionsMenu/index.jsxsuperset-frontend/src/explore/components/ExploreAdditionalActionsMenu/ExploreAdditionalActionsMenu.test.jsxsuperset-frontend/src/explore/components/ExploreActionButtons.test.jsxsuperset-frontend/src/explore/components/ExploreViewContainer.test.jsxsuperset-frontend/src/explore/components/ExploreViewContainer.jsxsuperset-frontend/src/explore/components/ExploreChartPanel.test.jsxsuperset-frontend/src/explore/components/QueryAndSaveBtns.test.jsxsuperset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsxsuperset-frontend/src/explore/components/controls/SliderControl.jsxsuperset-frontend/src/explore/components/controls/SelectControl.test.jsxsuperset-frontend/src/explore/components/controls/SelectControl.jsxsuperset-frontend/src/explore/components/controls/FixedOrMetricControl/index.jsxsuperset-frontend/src/explore/components/controls/BoundsControl.jsxsuperset-frontend/src/explore/components/controls/TextAreaControl.jsxsuperset-frontend/src/explore/components/controls/MetricControl/MetricsControl.test.jsxsuperset-frontend/src/explore/components/controls/MetricControl/FilterDefinitionOption.jsxsuperset-frontend/src/explore/components/controls/MetricControl/FilterDefinitionOption.test.jsxsuperset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopoverTitle.test.jsxsuperset-frontend/src/explore/components/controls/MetricControl/MetricDefinitionValue.jsxsuperset-frontend/src/explore/components/controls/MetricControl/AdhocMetricOption.test.jsxsuperset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.jsxsuperset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/index.jsxsuperset-frontend/src/explore/components/controls/MetricControl/AdhocMetricOption.jsxsuperset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopoverTitle.jsxsuperset-frontend/src/explore/components/controls/MetricControl/MetricDefinitionOption.jsxsuperset-frontend/src/explore/components/controls/MetricControl/MetricDefinitionValue.test.jsxsuperset-frontend/src/explore/components/controls/MetricControl/AggregateOption.jsxsuperset-frontend/src/explore/components/controls/MetricControl/MetricDefinitionOption.test.jsxsuperset-frontend/src/explore/components/controls/MetricControl/MetricsControl.jsxsuperset-frontend/src/explore/components/controls/SpatialControl.jsxsuperset-frontend/src/explore/components/controls/VizTypeControl/VizTypeControl.test.jsxsuperset-frontend/src/explore/components/controls/ColorPickerControl.jsxsuperset-frontend/src/explore/components/controls/ViewportControl.test.jsxsuperset-frontend/src/explore/components/controls/ViewportControl.jsxsuperset-frontend/src/explore/components/controls/DatasourceControl/index.jsxsuperset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.jsxsuperset-frontend/src/explore/components/controls/FilterBoxItemControl/FilterBoxItemControl.test.jsxsuperset-frontend/src/explore/components/controls/FilterBoxItemControl/index.jsxsuperset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/index.jsxsuperset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/AdhocFilterEditPopover.test.jsxsuperset-frontend/src/explore/components/controls/FilterControl/AdhocFilterControl/index.jsxsuperset-frontend/src/explore/components/controls/FilterControl/AdhocFilterControl/AdhocFilterControl.test.jsxsuperset-frontend/src/explore/components/controls/FilterControl/AdhocFilterOption/index.jsxsuperset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSqlTabContent/index.jsxsuperset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSqlTabContent/AdhocFilterEditPopoverSqlTabContent.test.jsxsuperset-frontend/src/explore/components/controls/BoundsControl.test.jsxsuperset-frontend/src/explore/components/controls/CollectionControl/index.jsxsuperset-frontend/src/explore/components/controls/TextAreaControl.test.jsxsuperset-frontend/src/explore/components/controls/ColorSchemeControl/index.jsxsuperset-frontend/src/explore/components/controls/ColorSchemeControl/ColorScheme.test.jsxsuperset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelectPopoverTitle.jsxsuperset-frontend/src/explore/components/controls/CheckboxControl.jsxsuperset-frontend/src/explore/components/controls/AnnotationLayerControl/index.jsxsuperset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsxsuperset-frontend/src/explore/components/EmbedCodeButton.jsxsuperset-frontend/src/explore/components/RowCountLabel.test.jsxsuperset-frontend/src/explore/components/ExploreChartPanel.jsxsuperset-frontend/src/explore/components/RowCountLabel.jsxsuperset-frontend/src/explore/components/QueryAndSaveBtns.jsxsuperset-frontend/src/explore/components/ExploreChartHeader/index.jsxsuperset-frontend/src/explore/components/ControlHeader.jsxsuperset-frontend/src/explore/components/SaveModal.test.jsxsuperset-frontend/src/explore/components/EmbedCodeButton.test.jsxsuperset-frontend/src/CRUD/CollectionTable.test.jsxsuperset-frontend/src/views/CRUD/annotationlayers/AnnotationLayerModal.test.jsxsuperset-frontend/src/views/CRUD/annotationlayers/AnnotationLayersList.test.jsxsuperset-frontend/src/views/CRUD/alert/ExecutionLog.test.jsxsuperset-frontend/src/views/CRUD/alert/AlertList.test.jsxsuperset-frontend/src/views/CRUD/alert/AlertReportModal.test.jsxsuperset-frontend/src/views/CRUD/data/dataset/DatasetList.test.jsxsuperset-frontend/src/views/CRUD/data/savedquery/SavedQueryList.test.jsxsuperset-frontend/src/views/CRUD/data/savedquery/SavedQueryPreviewModal.test.jsxsuperset-frontend/src/views/CRUD/data/database/DatabaseModal/index.test.jsxsuperset-frontend/src/views/CRUD/data/database/DatabaseList.test.jsxsuperset-frontend/src/views/CRUD/chart/ChartList.test.jsxsuperset-frontend/src/views/CRUD/dashboard/DashboardList.test.jsxsuperset-frontend/src/views/CRUD/annotation/AnnotationList.test.jsxsuperset-frontend/src/views/CRUD/annotation/AnnotationModal.test.jsxsuperset-frontend/src/views/CRUD/csstemplates/CssTemplatesList.test.jsxsuperset-frontend/src/views/CRUD/csstemplates/CssTemplateModal.test.jsxsuperset-frontend/src/chart/ChartRenderer.jsxsuperset-frontend/src/chart/ChartRenderer.test.jsxsuperset-frontend/src/chart/Chart.jsxsuperset-frontend/src/chart/ChartContainer.jsxsuperset-frontend/src/utils/common.test.jsxsuperset-frontend/src/dashboard/containers/DashboardComponent.jsxsuperset-frontend/src/dashboard/containers/FilterScope.jsxsuperset-frontend/src/dashboard/containers/SliceAdder.jsxsuperset-frontend/src/dashboard/containers/Chart.jsxsuperset-frontend/src/dashboard/containers/DashboardHeader.jsxsuperset-frontend/src/dashboard/containers/DashboardGrid.jsxsuperset-frontend/src/dashboard/util/propShapes.jsxsuperset-frontend/src/dashboard/components/ColorSchemeControlWrapper.jsxsuperset-frontend/src/dashboard/components/filterscope/FilterScopeTree.jsxsuperset-frontend/src/dashboard/components/filterscope/renderFilterScopeTreeNodes.jsxsuperset-frontend/src/dashboard/components/filterscope/renderFilterFieldTreeNodes.jsxsuperset-frontend/src/dashboard/components/filterscope/FilterScopeSelector.jsxsuperset-frontend/src/dashboard/components/filterscope/FilterFieldItem.jsxsuperset-frontend/src/dashboard/components/filterscope/treeIcons.jsxsuperset-frontend/src/dashboard/components/filterscope/FilterFieldTree.jsxsuperset-frontend/src/dashboard/components/gridComponents/Row.jsxsuperset-frontend/src/dashboard/components/gridComponents/Markdown.test.jsxsuperset-frontend/src/dashboard/components/gridComponents/Tab.test.jsxsuperset-frontend/src/dashboard/components/gridComponents/ChartHolder.test.jsxsuperset-frontend/src/dashboard/components/gridComponents/Tabs.test.jsxsuperset-frontend/src/dashboard/components/gridComponents/new/NewColumn.test.jsxsuperset-frontend/src/dashboard/components/gridComponents/new/NewColumn.jsxsuperset-frontend/src/dashboard/components/gridComponents/new/NewMarkdown.jsxsuperset-frontend/src/dashboard/components/gridComponents/new/DraggableNewComponent.test.jsxsuperset-frontend/src/dashboard/components/gridComponents/new/NewTabs.test.jsxsuperset-frontend/src/dashboard/components/gridComponents/new/DraggableNewComponent.jsxsuperset-frontend/src/dashboard/components/gridComponents/new/NewHeader.jsxsuperset-frontend/src/dashboard/components/gridComponents/new/NewRow.jsxsuperset-frontend/src/dashboard/components/gridComponents/new/NewTabs.jsxsuperset-frontend/src/dashboard/components/gridComponents/new/NewRow.test.jsxsuperset-frontend/src/dashboard/components/gridComponents/new/NewHeader.test.jsxsuperset-frontend/src/dashboard/components/gridComponents/new/NewDivider.jsxsuperset-frontend/src/dashboard/components/gridComponents/new/NewDivider.test.jsxsuperset-frontend/src/dashboard/components/gridComponents/Markdown.jsxsuperset-frontend/src/dashboard/components/gridComponents/Column.jsxsuperset-frontend/src/dashboard/components/gridComponents/Tabs.jsxsuperset-frontend/src/dashboard/components/gridComponents/Chart.jsxsuperset-frontend/src/dashboard/components/gridComponents/Row.test.jsxsuperset-frontend/src/dashboard/components/gridComponents/Tab.jsxsuperset-frontend/src/dashboard/components/gridComponents/Column.test.jsxsuperset-frontend/src/dashboard/components/gridComponents/Divider.jsxsuperset-frontend/src/dashboard/components/gridComponents/Header.test.jsxsuperset-frontend/src/dashboard/components/gridComponents/Header.jsxsuperset-frontend/src/dashboard/components/gridComponents/Divider.test.jsxsuperset-frontend/src/dashboard/components/gridComponents/Chart.test.jsxsuperset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsxsuperset-frontend/src/dashboard/components/AddSliceCard.jsxsuperset-frontend/src/dashboard/components/DeleteComponentButton.jsxsuperset-frontend/src/dashboard/components/UndoRedoKeyListeners/index.jsxsuperset-frontend/src/dashboard/components/Header/index.jsxsuperset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsxsuperset-frontend/src/dashboard/components/SliceAdder.jsxsuperset-frontend/src/dashboard/components/CssEditor/index.jsxsuperset-frontend/src/dashboard/components/SliceAdder.test.jsxsuperset-frontend/src/dashboard/components/DashboardGrid.test.jsxsuperset-frontend/src/dashboard/components/resizable/ResizableContainer.jsxsuperset-frontend/src/dashboard/components/resizable/ResizableHandle.jsxsuperset-frontend/src/dashboard/components/PublishedStatus/index.jsxsuperset-frontend/src/dashboard/components/dnd/DragDroppable.jsxsuperset-frontend/src/dashboard/components/dnd/DragDroppable.test.jsxsuperset-frontend/src/dashboard/components/dnd/AddSliceDragPreview.jsxsuperset-frontend/src/dashboard/components/menu/WithPopoverMenu.test.jsxsuperset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.test.jsxsuperset-frontend/src/dashboard/components/Dashboard.jsxsuperset-frontend/src/dashboard/components/Dashboard.test.jsxsuperset-frontend/src/dashboard/components/PropertiesModal/PropertiesModal.test.jsxsuperset-frontend/src/dashboard/components/DashboardGrid.jsxsuperset-frontend/src/dashboard/components/MissingChart.jsxsuperset-frontend/src/showSavedQuery/utils.test.jsxsuperset-frontend/src/showSavedQuery/index.jsxsuperset-frontend/src/components/URLShortLinkButton/index.jsxsuperset-frontend/src/components/Select/OnPasteSelect.test.jsxsuperset-frontend/src/components/Select/OnPasteSelect.jsxsuperset-frontend/src/components/IconButton/IconButton.test.jsxsuperset-frontend/src/components/ModalTrigger/index.jsxsuperset-frontend/src/components/Form/LabeledErrorBoundInput.test.jsxsuperset-frontend/src/components/AnchorLink/AnchorLink.test.jsxsuperset-frontend/src/components/AnchorLink/index.jsxsuperset-frontend/src/components/MessageToasts/ToastContainer.jsxsuperset-frontend/src/components/MessageToasts/ToastPresenter.test.jsxsuperset-frontend/src/components/MessageToasts/Toast.test.jsxsuperset-frontend/src/components/FormRow/index.jsxsuperset-frontend/src/components/FormRow/FormRow.test.jsxsuperset-frontend/src/components/AlteredSliceTag/index.jsxsuperset-frontend/src/components/AlteredSliceTag/AlteredSliceTag.test.jsxsuperset-frontend/src/components/ConfirmStatusChange/ConfirmStatusChange.test.jsxsuperset-frontend/src/components/AsyncSelect/AsyncSelect.test.jsxsuperset-frontend/src/components/AsyncSelect/index.jsxsuperset-frontend/src/components/ListViewCard/ImageLoader.test.jsxsuperset-frontend/src/components/ListViewCard/ListViewCard.test.jsxsuperset-frontend/src/components/ListView/ListView.test.jsxsuperset-frontend/src/components/CopyToClipboard/index.jsxsuperset-frontend/src/components/IconTooltip/IconTooltip.test.jsxsuperset-frontend/src/components/ErrorBoundary/index.jsxsuperset-frontend/src/components/Datasource/ChangeDatasourceModal.test.jsxsuperset-frontend/src/components/Datasource/DatasourceEditor.jsxsuperset-frontend/src/components/Datasource/DatasourceEditor.test.jsxsuperset-frontend/src/components/Datasource/DatasourceModal.test.jsxsuperset-frontend/src/SqlLab/App.jsxsuperset-frontend/src/SqlLab/components/ExploreResultsButton/index.jsxsuperset-frontend/src/SqlLab/components/ExploreResultsButton/ExploreResultsButton.test.jsxsuperset-frontend/src/SqlLab/components/SaveQuery/SaveQuery.test.jsxsuperset-frontend/src/SqlLab/components/ResultSet/ResultSet.test.jsxsuperset-frontend/src/SqlLab/components/TabStatusIcon/TabStatusIcon.test.jsxsuperset-frontend/src/SqlLab/components/SouthPane/SouthPane.test.jsxsuperset-frontend/src/SqlLab/components/QuerySearch/QuerySearch.test.jsxsuperset-frontend/src/SqlLab/components/QueryTable/QueryTable.test.jsxsuperset-frontend/src/SqlLab/components/QueryTable/index.jsxsuperset-frontend/src/SqlLab/components/SqlEditor/index.jsxsuperset-frontend/src/SqlLab/components/SqlEditor/SqlEditor.test.jsxsuperset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.jsxsuperset-frontend/src/SqlLab/components/SqlEditorLeftBar/SqlEditorLeftBar.test.jsxsuperset-frontend/src/SqlLab/components/QueryStateLabel/QueryStateLabel.test.jsxsuperset-frontend/src/SqlLab/components/HighlightedSql/HighlightedSql.test.jsxsuperset-frontend/src/SqlLab/components/App/index.jsxsuperset-frontend/src/SqlLab/components/App/App.test.jsxsuperset-frontend/src/SqlLab/components/TableElement/TableElement.test.jsxsuperset-frontend/src/SqlLab/components/ExploreCtasResultsButton/index.jsxsuperset-frontend/src/SqlLab/components/QueryAutoRefresh/index.jsxsuperset-frontend/src/SqlLab/components/QueryAutoRefresh/QueryAutoRefresh.test.jsxsuperset-frontend/src/SqlLab/components/TabbedSqlEditors/index.jsxsuperset-frontend/src/SqlLab/components/TabbedSqlEditors/TabbedSqlEditors.test.jsxsuperset-frontend/src/SqlLab/components/ShareSqlLabQuery/ShareSqlLabQuery.test.jsxsuperset-frontend/src/SqlLab/components/RunQueryActionButton/RunQueryActionButton.test.jsxsuperset-frontend/.storybook/preview.jsxsuperset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsxsuperset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/PivotTable.jsxsuperset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-style/ThemeStories.jsxsuperset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-time-format/TimeFormatStories.jsxsuperset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-color/RenderPalettes.jsxsuperset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-color/ColorPallettesStories.jsxsuperset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-number-format/BigNumberStories.jsxDescribe alternatives you've considered
We can still migrate the component when we touch it. However, there is no guarantee of an endless time that the full benefits of TypeScript and code consistency will be achieved.
We will also lose potential new contributors who start there and then move on to more complex issues.
Additional context
At Slack @nytai commented about migration components without functional changes:
The text was updated successfully, but these errors were encountered: