Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native filter] filters are displayed as out of scope if there are tabs on dashboard #18040

Closed
3 tasks done
jinghua-qa opened this issue Jan 14, 2022 · 1 comment
Closed
3 tasks done
Labels
#bug Bug report preset:QA Preset QA team preset-io

Comments

@jinghua-qa
Copy link
Member

filters are displayed as out of scope if there are tabs on dashboard

How to reproduce the bug

1,Open any dashboard with tabs (e.g. use `Sales Dashboard) or use your own
2,Create a native filter (e.g. time range) and apply it to all panels
3,Save the filter
4,Go to the "Dashboards" page
5,Open the dashboard from step 1
6,Pay attention to the native filter bar

Expected results

the scope of the filters has not changed for dashboard with tabs

Actual results

filter is displayed as out of scope on if there are tabs on dashboard (after re-visiting the dashboard), see the video below:

Screenshots

outofscope.mp4

Environment

(please complete the following information):

  • browser type and version:
  • superset version: master
  • python version: python --version
  • node.js version: node -v
  • any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@jinghua-qa
Copy link
Member Author

Verified fix on superset master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report preset:QA Preset QA team preset-io
Projects
None yet
Development

No branches or pull requests

1 participant