Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chart]Label type selection not working on Pie chart #12989

Closed
3 tasks done
syazshafei opened this issue Feb 7, 2021 · 2 comments · Fixed by #13052
Closed
3 tasks done

[chart]Label type selection not working on Pie chart #12989

syazshafei opened this issue Feb 7, 2021 · 2 comments · Fixed by #13052
Labels
#bug:regression Bugs that are identified as regessions good first issue Good first issues for new contributors viz:charts:pie Related to the Pie chart

Comments

@syazshafei
Copy link

syazshafei commented Feb 7, 2021

A clear and concise description of what the bug is.

Expected results

Label type changed

Actual results

Label type doesn't changed

Screenshots

ZOoO4Gkebk

How to reproduce the bug

  1. Go to 'Charts'
  2. Click on 'any Pie chart.'
  3. Change Label Type
  4. See error

Environment

(please complete the following information):

  • superset version: master
  • python version: based on master
  • node.js version: based on master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@syazshafei syazshafei added the #bug Bug report label Feb 7, 2021
@junlincc junlincc added #bug:regression Bugs that are identified as regessions viz:charts:pie Related to the Pie chart and removed #bug Bug report labels Feb 7, 2021
@junlincc junlincc changed the title Label type selection not working on Pie chart [chart]Label type selection not working on Pie chart Feb 7, 2021
@junlincc junlincc added the good first issue Good first issues for new contributors label Feb 7, 2021
@junlincc
Copy link
Member

junlincc commented Feb 7, 2021

confirmed this is not working in master. also label disappear on hover.

Screen Shot 2021-02-06 at 6 45 36 PM

@villebro not sure it happens after we bumped echarts to 5.0.2?
apache/echarts#14108
tagged good first issue feel free to open a PR if you have a solution 😃

@villebro
Copy link
Member

villebro commented Feb 7, 2021

Bumping the version in the plugin here which fixes the hover issue: apache-superset/superset-ui#942 Will add a fix for the type bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:regression Bugs that are identified as regessions good first issue Good first issues for new contributors viz:charts:pie Related to the Pie chart
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants