Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bar chart: disabling "sort bars" doesn't reset sort order #12650

Closed
3 tasks
villebro opened this issue Jan 21, 2021 · 4 comments
Closed
3 tasks

bar chart: disabling "sort bars" doesn't reset sort order #12650

villebro opened this issue Jan 21, 2021 · 4 comments
Labels
#bug Bug report viz:charts:bar Related to the Bar chart

Comments

@villebro
Copy link
Member

When enabling "sort bars" and disabling again, the order isn't reset to the original order.

Expected results

The original order is restored.

Actual results

The data is sorted by x-axis.

Screenshots

bar-chart-sort

How to reproduce the bug

  1. Go to 'Genders by state' example chart
  2. Click on 'Customize'
  3. check 'sort bars'
  4. uncheck 'sort bars'
  5. See data ordered by x-axis

Environment

(please complete the following information):

  • superset version: master branch

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@villebro villebro added the #bug Bug report label Jan 21, 2021
@junlincc junlincc added viz:charts:bar Related to the Bar chart assigned:flexiana and removed #bug Bug report preset-io labels Jan 21, 2021
@zuzana-vej zuzana-vej added the !deprecated-label:bug Deprecated label - Use #bug instead label Apr 20, 2021
@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 17, 2022
@rusackas
Copy link
Member

rusackas commented Feb 2, 2023

@yousoph this still seems to be a legit issue in the ECharts bar chart... I can't get the sorting to work. Holler if we need a ticket and a preset:cares label on this

@stale stale bot removed the inactive Inactive for >= 30 days label Feb 2, 2023
@rusackas rusackas added #bug Bug report and removed !deprecated-label:bug Deprecated label - Use #bug instead labels Feb 2, 2023
@sfirke
Copy link
Member

sfirke commented Apr 27, 2023

This was fixed in legacy bar charts with #19371.

As to ECharts, I can't replicate this issue in 2.1.0 with the ECharts Bar Chart. There's not that same "Sort Bars" box anymore and I'm able to switch between sorting variables and ascending/descending just fine.

@rusackas
Copy link
Member

Given the feedback above, I think we can just close this. Please holler, anyone, if this needs re-opening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report viz:charts:bar Related to the Bar chart
Projects
None yet
Development

No branches or pull requests

6 participants