Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQL Lab] broken in Safari #12565

Closed
3 tasks done
betodealmeida opened this issue Jan 15, 2021 · 0 comments · Fixed by #12973
Closed
3 tasks done

[SQL Lab] broken in Safari #12565

betodealmeida opened this issue Jan 15, 2021 · 0 comments · Fixed by #12973
Assignees
@betodealmeida
Labels
browser:safari Related to the Safari browser sqllab:editor

Comments

@betodealmeida
Copy link
Member

The text area has no height.

Screenshots

Screen Shot 2021-01-15 at 1 57 57 PM

How to reproduce the bug

Open SQL Lab in Safari.

Environment

(please complete the following information):

  • superset version: master
  • python version: 3.8.2
  • node.js version: v14.11.0

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

N/A
@betodealmeida betodealmeida added the #bug Bug report label Jan 15, 2021
@betodealmeida betodealmeida mentioned this issue Jan 15, 2021
Merged
6 tasks
@junlincc junlincc added browser:safari Related to the Safari browser sqllab:editor and removed #bug Bug report labels Jan 15, 2021
@junlincc junlincc changed the title SQL Lab broken in Safari [SQL Lab] broken in Safari Jan 15, 2021
@betodealmeida betodealmeida self-assigned this Feb 5, 2021
@betodealmeida betodealmeida mentioned this issue Feb 5, 2021
Merged
6 tasks
@laxmanraparthi laxmanraparthi mentioned this issue Jan 15, 2024
Open
This was referenced Mar 11, 2024
Open
Closed
@matrix-compute matrix-compute mentioned this issue Mar 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@betodealmeida betodealmeida

Labels
browser:safari Related to the Safari browser sqllab:editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: SQL Lab editor height in Safari betodealmeida/incubator-superset
2 participants
@betodealmeida @junlincc