Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataset in Chart CRUD view no longer include schema name #11265

Closed
etr2460 opened this issue Oct 14, 2020 · 1 comment · Fixed by #11278
Closed

Dataset in Chart CRUD view no longer include schema name #11265

etr2460 opened this issue Oct 14, 2020 · 1 comment · Fixed by #11278
Assignees
@nytai
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed !deprecated-label:bug Deprecated label - Use #bug instead

Comments

@etr2460
Copy link
Member

etr2460 commented Oct 14, 2020

Screenshot

image

Description

Because the schema name is removed, and there's no indication of the database backing the chart, we lose a lot of context for charts backed by certain tables/dbs. In the example here, the chart was backed by the minerva.all table in Minerva-DB, but we have no context other than dataset name = all

Design input

Perhaps add a database column, or readd schemas to the dataset column
@etr2460 etr2460 added the #bug:cosmetic Cosmetic/layout/design tweak needed label Oct 14, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.78. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the !deprecated-label:bug Deprecated label - Use #bug instead label Oct 14, 2020
@etr2460 etr2460 mentioned this issue Oct 14, 2020
Merged
@nytai nytai mentioned this issue Oct 14, 2020
Merged
6 tasks
@nytai nytai linked a pull request Oct 14, 2020 that will close this issue
fix: add schema name to datasource field in chart list #11278
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nytai nytai

Labels
#bug:cosmetic Cosmetic/layout/design tweak needed !deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add schema name to datasource field in chart list preset-io/superset
2 participants
@etr2460 @nytai