Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No sandbox.js ? chart tooltips #10808

Closed
eried opened this issue Sep 7, 2020 · 6 comments · Fixed by #23005
Closed

No sandbox.js ? chart tooltips #10808

eried opened this issue Sep 7, 2020 · 6 comments · Fixed by #23005
Labels
!deprecated-label:bug Deprecated label - Use #bug instead inactive Inactive for >= 30 days viz:charts:deck.gl Related to deck.gl charts

Comments

@eried
Copy link

eried commented Sep 7, 2020

I am trying to add tooltips to a deck.gl Scatterplot, but I cannot find any documentation and the link for sandbox.js is broken

Expected results

Any type of documentation on how to add tooltips with "Extra data for JS"

Actual results

No documentation, broken link to the sourcecode

Screenshots

image

How to reproduce the bug

  1. Add a chart using deck.gl Scatterplot
  2. Edit the chart
  3. In Advanced -> Edit javascript in modal
  4. See error
@eried eried added the !deprecated-label:bug Deprecated label - Use #bug instead label Sep 7, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.69. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@jtotoole
Copy link

Broken link (https://github.com/apache/incubator-superset/blob/master/superset/assets/src/modules/sandbox.js) is here: https://github.com/apache/incubator-superset/blob/7f1012360a8c0dd6860e80f852026017c09b746c/superset-frontend/src/explore/controlPanels/Shared_DeckGL.jsx#L33-L34

I don't see a sandbox.js file anywhere in the project at this point, so I'm not sure what that should be corrected to.

This should probably be two separate issues: one for the broken link and one for the lack of documentation on user-defined functions for Deck.gl visualizations, which has also been mentioned here:

#7174
#6020

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Dec 25, 2020
@SofieneBr
Copy link

SofieneBr commented Nov 2, 2021

Anyone able to use the javascipt features of the Deck.gl visualizations ?
I'm currently using the latest docker release

@stale stale bot removed the inactive Inactive for >= 30 days label Nov 2, 2021
@junlincc junlincc added the viz:charts:deck.gl Related to deck.gl charts label Nov 17, 2021
@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 17, 2022
@rusackas
Copy link
Member

rusackas commented Feb 6, 2023

Just opened a PR to update the broken link. The tooltip's functionality is a whole other topic, and any issues relevant to Superset 2.0.1 should be taken up separately, especially since this thread is so old/stale. The PR should close this acute issue when it merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead inactive Inactive for >= 30 days viz:charts:deck.gl Related to deck.gl charts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants