From e29d71d0ffb06ef401916a6ccac53edc59f5f75d Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Mon, 13 Jun 2016 22:58:04 -0700 Subject: [PATCH] [hotfix] passing payload to Slice.done everywhere --- caravel/assets/visualizations/heatmap.js | 2 +- caravel/assets/visualizations/horizon.js | 2 +- caravel/assets/visualizations/iframe.js | 2 +- caravel/assets/visualizations/markup.js | 2 +- caravel/assets/visualizations/parallel_coordinates.js | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/caravel/assets/visualizations/heatmap.js b/caravel/assets/visualizations/heatmap.js index 18aa2eea3fb9d..a063f0be4b718 100644 --- a/caravel/assets/visualizations/heatmap.js +++ b/caravel/assets/visualizations/heatmap.js @@ -222,7 +222,7 @@ function heatmapVis(slice) { imageObj.src = canvas.node().toDataURL(); } - slice.done(); + slice.done(payload); }); } diff --git a/caravel/assets/visualizations/horizon.js b/caravel/assets/visualizations/horizon.js index c8f3e3d201413..23dc02aaaf0db 100644 --- a/caravel/assets/visualizations/horizon.js +++ b/caravel/assets/visualizations/horizon.js @@ -225,7 +225,7 @@ function horizonViz(slice) { .call(this, d.values, i); }); - slice.done(); + slice.done(payload); }); } return { diff --git a/caravel/assets/visualizations/iframe.js b/caravel/assets/visualizations/iframe.js index c38feff30d38a..d7c87aade753e 100644 --- a/caravel/assets/visualizations/iframe.js +++ b/caravel/assets/visualizations/iframe.js @@ -10,7 +10,7 @@ function iframeWidget(slice) { var iframe = slice.container.find('iframe'); iframe.css('height', slice.height()); iframe.attr('src', url); - slice.done(); + slice.done(payload); }) .fail(function (xhr) { slice.error(xhr.responseText); diff --git a/caravel/assets/visualizations/markup.js b/caravel/assets/visualizations/markup.js index f202c92dd92b3..832e938df1637 100644 --- a/caravel/assets/visualizations/markup.js +++ b/caravel/assets/visualizations/markup.js @@ -7,7 +7,7 @@ function markupWidget(slice) { $.getJSON(slice.jsonEndpoint(), function (payload) { slice.container.html(payload.data.html); - slice.done(); + slice.done(payload); }) .fail(function (xhr) { slice.error(xhr.responseText); diff --git a/caravel/assets/visualizations/parallel_coordinates.js b/caravel/assets/visualizations/parallel_coordinates.js index 4f4b522164bc1..1cd501074726f 100644 --- a/caravel/assets/visualizations/parallel_coordinates.js +++ b/caravel/assets/visualizations/parallel_coordinates.js @@ -92,7 +92,7 @@ function parallelCoordVis(slice) { }); }); } - slice.done(); + slice.done(payload); }) .fail(function (xhr) { slice.error(xhr.responseText);