From e252405ead017ef1a57501ebdc2a709e916ba5d7 Mon Sep 17 00:00:00 2001 From: Diego Medina Date: Mon, 11 Jul 2022 12:56:54 -0300 Subject: [PATCH] PR comments --- .../src/components/Datasource/CollectionTable.tsx | 3 +-- .../src/explore/components/controls/TextAreaControl.jsx | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/superset-frontend/src/components/Datasource/CollectionTable.tsx b/superset-frontend/src/components/Datasource/CollectionTable.tsx index 68673f287b101..e0eb44e8453d2 100644 --- a/superset-frontend/src/components/Datasource/CollectionTable.tsx +++ b/superset-frontend/src/components/Datasource/CollectionTable.tsx @@ -344,8 +344,7 @@ export default class CRUDCollection extends React.PureComponent< } getCellProps(record: any, col: any) { - const cellPropsFn = - this.props.itemCellProps && this.props.itemCellProps[col]; + const cellPropsFn = this.props.itemCellProps?.[col]; const val = record[col]; return cellPropsFn ? cellPropsFn(val, this.getLabel(col), record) : {}; } diff --git a/superset-frontend/src/explore/components/controls/TextAreaControl.jsx b/superset-frontend/src/explore/components/controls/TextAreaControl.jsx index afeecb90fd106..48582c4bc757c 100644 --- a/superset-frontend/src/explore/components/controls/TextAreaControl.jsx +++ b/superset-frontend/src/explore/components/controls/TextAreaControl.jsx @@ -65,7 +65,7 @@ const defaultProps = { maxLines: 10, offerEditInModal: true, readOnly: false, - resize: false, + resize: null, textAreaStyles: {}, };