Add previous line hotkey to SQL editor for macOS (#19052)

apache · Mar 8, 2022 · aa0ec71 · aa0ec71
1 parent 03b2b06
commit aa0ec71
Showing 1 changed file with 15 additions and 1 deletion.
diff --git a/superset-frontend/src/SqlLab/components/SqlEditor/index.jsx b/superset-frontend/src/SqlLab/components/SqlEditor/index.jsx
@@ -306,7 +306,8 @@ class SqlEditor extends React.PureComponent {
   getHotkeyConfig() {
     // Get the user's OS
     const userOS = detectOS();
-    return [
+
+    const base = [
       {
         name: 'runQuery1',
         key: 'ctrl+r',
@@ -346,6 +347,19 @@ class SqlEditor extends React.PureComponent {
         func: this.stopQuery,
       },
     ];
+
+    if (userOS === 'MacOS') {
+      base.push({
+        name: 'previousLine',
+        key: 'ctrl+p',
+        descr: t('Previous Line'),
+        func: editor => {
+          editor.navigateUp(1);
+        },
+      });
+    }
+
+    return base;
   }
 
   setQueryEditorSql(sql) {