From a10d259269433f40e1c4da8e9f60081fbe446edb Mon Sep 17 00:00:00 2001
From: Yongjie Zhao <yongjie.zhao@gmail.com>
Date: Mon, 31 Oct 2022 18:17:18 +0800
Subject: [PATCH] fix label error when custom SQL => simple panel

---
 .../utils/useGetTimeRangeLabel.test.ts        | 103 ++++++++++++++++++
 .../utils/useGetTimeRangeLabel.tsx            |  11 +-
 2 files changed, 111 insertions(+), 3 deletions(-)
 create mode 100644 superset-frontend/src/explore/components/controls/FilterControl/utils/useGetTimeRangeLabel.test.ts

diff --git a/superset-frontend/src/explore/components/controls/FilterControl/utils/useGetTimeRangeLabel.test.ts b/superset-frontend/src/explore/components/controls/FilterControl/utils/useGetTimeRangeLabel.test.ts
new file mode 100644
index 0000000000000..0d39ef8a27041
--- /dev/null
+++ b/superset-frontend/src/explore/components/controls/FilterControl/utils/useGetTimeRangeLabel.test.ts
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { renderHook } from '@testing-library/react-hooks';
+import { NO_TIME_RANGE } from '@superset-ui/core';
+import { Operators } from 'src/explore/constants';
+import * as FetchTimeRangeModule from 'src/explore/components/controls/DateFilterControl';
+import { useGetTimeRangeLabel } from './useGetTimeRangeLabel';
+import AdhocFilter, { CLAUSES, EXPRESSION_TYPES } from '../AdhocFilter';
+
+test('should return empty object if operator is not TEMPORAL_RANGE', () => {
+  const adhocFilter = new AdhocFilter({
+    expressionType: EXPRESSION_TYPES.SIMPLE,
+    subject: 'value',
+    operator: '>',
+    comparator: '10',
+    clause: CLAUSES.WHERE,
+  });
+  const { result } = renderHook(() => useGetTimeRangeLabel(adhocFilter));
+  expect(result.current).toEqual({});
+});
+
+test('should return empty object if expressionType is SQL', () => {
+  const adhocFilter = new AdhocFilter({
+    expressionType: EXPRESSION_TYPES.SQL,
+    subject: 'temporal column',
+    operator: Operators.TEMPORAL_RANGE,
+    comparator: 'Last week',
+    clause: CLAUSES.WHERE,
+  });
+  const { result } = renderHook(() => useGetTimeRangeLabel(adhocFilter));
+  expect(result.current).toEqual({});
+});
+
+test('should get "No filter" label', () => {
+  const adhocFilter = new AdhocFilter({
+    expressionType: EXPRESSION_TYPES.SIMPLE,
+    subject: 'temporal column',
+    operator: Operators.TEMPORAL_RANGE,
+    comparator: NO_TIME_RANGE,
+    clause: CLAUSES.WHERE,
+  });
+  const { result } = renderHook(() => useGetTimeRangeLabel(adhocFilter));
+  expect(result.current).toEqual({
+    actualTimeRange: 'temporal column (No filter)',
+    title: 'No filter',
+  });
+});
+
+test('should get actualTimeRange and title', async () => {
+  jest
+    .spyOn(FetchTimeRangeModule, 'fetchTimeRange')
+    .mockResolvedValue({ value: 'MOCK TIME' });
+
+  const adhocFilter = new AdhocFilter({
+    expressionType: EXPRESSION_TYPES.SIMPLE,
+    subject: 'temporal column',
+    operator: Operators.TEMPORAL_RANGE,
+    comparator: 'Last week',
+    clause: CLAUSES.WHERE,
+  });
+
+  const { result } = await renderHook(() => useGetTimeRangeLabel(adhocFilter));
+  expect(result.current).toEqual({
+    actualTimeRange: 'MOCK TIME',
+    title: 'Last week',
+  });
+});
+
+test('should get actualTimeRange and title when gets an error', async () => {
+  jest
+    .spyOn(FetchTimeRangeModule, 'fetchTimeRange')
+    .mockResolvedValue({ error: 'MOCK ERROR' });
+
+  const adhocFilter = new AdhocFilter({
+    expressionType: EXPRESSION_TYPES.SIMPLE,
+    subject: 'temporal column',
+    operator: Operators.TEMPORAL_RANGE,
+    comparator: 'Last week',
+    clause: CLAUSES.WHERE,
+  });
+
+  const { result } = await renderHook(() => useGetTimeRangeLabel(adhocFilter));
+  expect(result.current).toEqual({
+    actualTimeRange: 'temporal column (Last week)',
+    title: 'MOCK ERROR',
+  });
+});
diff --git a/superset-frontend/src/explore/components/controls/FilterControl/utils/useGetTimeRangeLabel.tsx b/superset-frontend/src/explore/components/controls/FilterControl/utils/useGetTimeRangeLabel.tsx
index 6181104ad0e6e..abc2ad5b27c91 100644
--- a/superset-frontend/src/explore/components/controls/FilterControl/utils/useGetTimeRangeLabel.tsx
+++ b/superset-frontend/src/explore/components/controls/FilterControl/utils/useGetTimeRangeLabel.tsx
@@ -18,9 +18,9 @@
  */
 import { useEffect, useState } from 'react';
 import { NO_TIME_RANGE } from '@superset-ui/core';
-import AdhocFilter from 'src/explore/components/controls/FilterControl/AdhocFilter';
 import { fetchTimeRange } from 'src/explore/components/controls/DateFilterControl';
 import { Operators } from 'src/explore/constants';
+import AdhocFilter, { EXPRESSION_TYPES } from '../AdhocFilter';
 
 interface Results {
   actualTimeRange?: string;
@@ -31,7 +31,10 @@ export const useGetTimeRangeLabel = (adhocFilter: AdhocFilter): Results => {
   const [actualTimeRange, setActualTimeRange] = useState<Results>({});
 
   useEffect(() => {
-    if (adhocFilter.operator !== Operators.TEMPORAL_RANGE) {
+    if (
+      adhocFilter.operator !== Operators.TEMPORAL_RANGE ||
+      adhocFilter.expressionType !== EXPRESSION_TYPES.SIMPLE
+    ) {
       setActualTimeRange({});
     }
     if (
@@ -46,7 +49,9 @@ export const useGetTimeRangeLabel = (adhocFilter: AdhocFilter): Results => {
 
     if (
       adhocFilter.operator === Operators.TEMPORAL_RANGE &&
-      adhocFilter.comparator !== NO_TIME_RANGE
+      adhocFilter.expressionType === EXPRESSION_TYPES.SIMPLE &&
+      adhocFilter.comparator !== NO_TIME_RANGE &&
+      actualTimeRange.title !== adhocFilter.comparator
     ) {
       fetchTimeRange(adhocFilter.comparator, adhocFilter.subject).then(
         ({ value, error }) => {