- Are you sure you want to overwrite this dataset?
+
+ }
+ >
+
+ {!shouldOverwriteDataset && (
+
+
+ Save this query as virtual dataset to continue exploring.
- )}
-
-
- );
-};
+
+
+ Save as new
+
+
+
+ Overwrite existing
+
+
+
+
+ Are you sure you want to overwrite this dataset?
+
+ )}
+
+
+);
diff --git a/superset-frontend/src/SqlLab/components/SaveQuery.tsx b/superset-frontend/src/SqlLab/components/SaveQuery.tsx
index 997203e220816..04dc673b84740 100644
--- a/superset-frontend/src/SqlLab/components/SaveQuery.tsx
+++ b/superset-frontend/src/SqlLab/components/SaveQuery.tsx
@@ -79,13 +79,11 @@ export default function SaveQuery({
const [showSave, setShowSave] = useState
(false);
const isSaved = !!query.remoteId;
- const queryPayload = () => {
- return {
- ...query,
- title: label,
- description,
- };
- };
+ const queryPayload = () => ({
+ ...query,
+ title: label,
+ description,
+ });
const close = () => {
setShowSave(false);
@@ -113,47 +111,45 @@ export default function SaveQuery({
setShowSave(!showSave);
};
- const renderModalBody = () => {
- return (
-
-
-
-
- {t('Name')}
-
-
-
-
-
-
-
-
- {t('Description')}
-
-
-
-
- {saveQueryWarning && (
- <>
+ const renderModalBody = () => (
+
+
+
+
+ {t('Name')}
+
+
+
+
+
+
+
+
+ {t('Description')}
+
+
+
+
+ {saveQueryWarning && (
+ <>
+
+
+
+
+ {saveQueryWarning}
+
+
-
-
-
- {saveQueryWarning}
-
-
-
-
-
- )}
-
- );
- };
+
{iconName}
-
- ))}
-
- );
-};
+export const SupersetIcon = () => (
+
+ {Object.keys(iconsRegistry)
+ .sort()
+ .map(iconName => (
+
+
+ {iconName}
+
+ ))}
+
+);
diff --git a/superset-frontend/src/components/ListView/CardCollection.tsx b/superset-frontend/src/components/ListView/CardCollection.tsx
index 9e9e268fc99df..a0a0a98ce9a1e 100644
--- a/superset-frontend/src/components/ListView/CardCollection.tsx
+++ b/superset-frontend/src/components/ListView/CardCollection.tsx
@@ -68,9 +68,9 @@ export default function CardCollection({
{loading &&
rows.length === 0 &&
- [...new Array(25)].map((e, i) => {
- return {renderCard({ loading })}
;
- })}
+ [...new Array(25)].map((e, i) => (
+ {renderCard({ loading })}
+ ))}
{rows.length > 0 &&
rows.map(row => {
if (!renderCard) return null;
diff --git a/superset-frontend/src/components/ListView/ListView.tsx b/superset-frontend/src/components/ListView/ListView.tsx
index 3f664f1f238ea..6ee998cc3560d 100644
--- a/superset-frontend/src/components/ListView/ListView.tsx
+++ b/superset-frontend/src/components/ListView/ListView.tsx
@@ -174,34 +174,32 @@ const ViewModeToggle = ({
}: {
mode: 'table' | 'card';
setMode: (mode: 'table' | 'card') => void;
-}) => {
- return (
-
- {
- e.currentTarget.blur();
- setMode('card');
- }}
- className={cx('toggle-button', { active: mode === 'card' })}
- >
-
-
- {
- e.currentTarget.blur();
- setMode('table');
- }}
- className={cx('toggle-button', { active: mode === 'table' })}
- >
-
-
-
- );
-};
+}) => (
+
+ {
+ e.currentTarget.blur();
+ setMode('card');
+ }}
+ className={cx('toggle-button', { active: mode === 'card' })}
+ >
+
+
+ {
+ e.currentTarget.blur();
+ setMode('table');
+ }}
+ className={cx('toggle-button', { active: mode === 'table' })}
+ >
+
+
+
+);
export interface ListViewProps {
columns: any[];
diff --git a/superset-frontend/src/components/ListViewCard/ListViewCard.stories.tsx b/superset-frontend/src/components/ListViewCard/ListViewCard.stories.tsx
index 6daf43d5fd00b..5f716c01f8d48 100644
--- a/superset-frontend/src/components/ListViewCard/ListViewCard.stories.tsx
+++ b/superset-frontend/src/components/ListViewCard/ListViewCard.stories.tsx
@@ -41,49 +41,43 @@ const imgFallbackKnob = {
defaultValue: DashboardImg,
};
-export const SupersetListViewCard = () => {
- return (
-
-
-
-
- Delete
-
-
- Edit
-
-
- }
- >
-
-
-
- }
- />
- );
-};
+export const SupersetListViewCard = () => (
+
+
+
+
+ Delete
+
+
+ Edit
+
+
+ }
+ >
+
+
+
+ }
+ />
+);
diff --git a/superset-frontend/src/components/Select/Select.stories.tsx b/superset-frontend/src/components/Select/Select.stories.tsx
index 74ae743a79640..dc10420346b73 100644
--- a/superset-frontend/src/components/Select/Select.stories.tsx
+++ b/superset-frontend/src/components/Select/Select.stories.tsx
@@ -49,45 +49,43 @@ export default {
},
};
-export const SelectGallery = ({ value }: { value: OptionTypeBase }) => {
- return (
- <>
- With default value
-