From 6bf8596d681086255f36633910720b0662fe13a5 Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Tue, 30 Jul 2024 12:46:14 -0700 Subject: [PATCH] fix: remove --no-optional from docker-compose build (#29779) --- docker-compose.yml | 1 + docker/docker-frontend.sh | 10 +++++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/docker-compose.yml b/docker-compose.yml index de0f12db2e7c8..aa8d940a8cdef 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -151,6 +151,7 @@ services: environment: # set this to false if you have perf issues running the npm i; npm run dev in-docker # if you do so, you have to run this manually on the host, which should perform better! + BUILD_SUPERSET_FRONTEND_IN_DOCKER: true SCARF_ANALYTICS: "${SCARF_ANALYTICS:-}" container_name: superset_node command: ["/app/docker/docker-frontend.sh"] diff --git a/docker/docker-frontend.sh b/docker/docker-frontend.sh index aad6e0a16d5b6..bb46c07f988f5 100755 --- a/docker/docker-frontend.sh +++ b/docker/docker-frontend.sh @@ -24,12 +24,16 @@ if [ "$PUPPETEER_SKIP_CHROMIUM_DOWNLOAD" = "false" ]; then fi if [ "$BUILD_SUPERSET_FRONTEND_IN_DOCKER" = "true" ]; then + echo "Building Superset frontend in dev mode inside docker container" cd /app/superset-frontend - npm install -f --no-optional --global webpack webpack-cli - npm install -f + + echo "Running `npm install`" + npm install echo "Running frontend" npm run dev + else - echo "Skipping frontend build steps - YOU RUN IT MANUALLY ON THE HOST!" + echo "Skipping frontend build steps - YOU NEED TO RUN IT MANUALLY ON THE HOST!" + echo "https://superset.apache.org/docs/contributing/development/#webpack-dev-server" fi