From 1c48fe05fd291517350ad57bb175ce8155b23580 Mon Sep 17 00:00:00 2001
From: John Bodley <4567245+john-bodley@users.noreply.github.com>
Date: Mon, 20 May 2024 11:30:56 -0700
Subject: [PATCH] fix: Update migration logic in #27119 (#28482)

---
 UPDATING.md                                   |  1 +
 ...6750b67e8_change_mediumtext_to_longtext.py | 54 +++++++++++++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 superset/migrations/versions/2024-05-09_19-19_f7b6750b67e8_change_mediumtext_to_longtext.py

diff --git a/UPDATING.md b/UPDATING.md
index 909cd9f6d9bed..67be28ba913b6 100644
--- a/UPDATING.md
+++ b/UPDATING.md
@@ -84,6 +84,7 @@ assists people when migrating to a new version.
 ### Potential Downtime
 
 - [26416](https://github.com/apache/superset/pull/26416): Adds two database indexes to the `report_execution_log` table and one database index to the `report_recipient` to improve performance. Scheduled downtime may be required for large deployments.
+- [28482](https://github.com/apache/superset/pull/28482): Potentially augments the `query.executed_sql` and `query.select_sql` columns for MySQL from `MEDIUMTEXT` to `LONGTEXT`. Potential downtime may be required for large deployments which previously ran [27119](https://github.com/apache/superset/pull/27119).
 
 ## 3.1.0
 
diff --git a/superset/migrations/versions/2024-05-09_19-19_f7b6750b67e8_change_mediumtext_to_longtext.py b/superset/migrations/versions/2024-05-09_19-19_f7b6750b67e8_change_mediumtext_to_longtext.py
new file mode 100644
index 0000000000000..77235cca9eff9
--- /dev/null
+++ b/superset/migrations/versions/2024-05-09_19-19_f7b6750b67e8_change_mediumtext_to_longtext.py
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""change_mediumtext_to_longtext
+Revision ID: f7b6750b67e8
+Revises: f84fde59123a
+Create Date: 2024-05-09 19:19:46.630140
+"""
+
+# revision identifiers, used by Alembic.
+revision = "f7b6750b67e8"
+down_revision = "f84fde59123a"
+
+from alembic import op  # noqa: E402
+from sqlalchemy.dialects.mysql import MEDIUMTEXT  # noqa: E402
+from sqlalchemy.dialects.mysql.base import MySQLDialect  # noqa: E402
+
+from superset.migrations.shared.utils import get_table_column  # noqa: E402
+from superset.utils.core import LongText, MediumText  # noqa: E402
+
+
+def upgrade():
+    if isinstance(op.get_bind().dialect, MySQLDialect):
+        for item in ["query.executed_sql", "query.select_sql"]:
+            table_name, column_name = item.split(".")
+
+            if (column := get_table_column(table_name, column_name)) and isinstance(
+                column["type"],
+                MEDIUMTEXT,
+            ):
+                with op.batch_alter_table(table_name) as batch_op:
+                    batch_op.alter_column(
+                        column_name,
+                        existing_type=MediumText(),
+                        type_=LongText(),
+                        existing_nullable=True,
+                    )
+
+
+def downgrade():
+    pass