WW-5417 bump ognl version to fix security issue #915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferyxhy
commented
Apr 18, 2024
pom.xml
Outdated
| <jackson.version>2.16.1</jackson.version> | ||
| <log4j2.version>2.23.1</log4j2.version> | ||
| <ognl.version>3.3.4</ognl.version> | ||
| <ognl.version>3.3.4-atlassian-1</ognl.version> |
Author
There was a problem hiding this comment.
To be replaced with 3.3.5 once released OGNL patch PR
Member
There was a problem hiding this comment.
Try you to use 3.3.5 verision
kusalk
reviewed
Apr 18, 2024
| } | ||
|
|
||
|
|
||
| public static class HolderWithPublicField { |
Member
There was a problem hiding this comment.
@lukaszlenart This is a PoC of the original public field bug I reported
kusalk
reviewed
Apr 18, 2024
| } | ||
| } | ||
|
|
||
| public static class HolderWhoseFieldWithPublicSetterDifferentFieldName { |
Member
There was a problem hiding this comment.
@lukaszlenart This is a PoC of the new public setter bug discovered by @jefferyxhy
Member
|
Remaining tests are variations for full coverage and to prevent regressions |
Member
|
The builds are failing as the Atlassian forked release is not on the Central repo, it is only available on our repo. |
jefferyxhy
commented
Apr 19, 2024
| <jackson.version>2.16.1</jackson.version> | ||
| <log4j2.version>2.23.1</log4j2.version> | ||
| <ognl.version>3.3.4</ognl.version> | ||
| <ognl.version>3.3.5</ognl.version> |
kusalk
deleted the
issue/WW-5417-bump-ongl-version-to-fix-security-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WW-5417
bump the Ognl version to fix the security issue that
ObjectPropertyAccessor#setPossiblePropertybypass SecurityMemberAccess right check.*********************** From Ognl PR ***********************
OgnlRuntime.setFieldValuedoesn't check member access rights viaMemberAccessinterfaceReason
getMethodValue/setMethodValue/getFieldValueare all updated with member access rights check but notsetFieldValue, which causeObjectPropertyAccessor#setPossiblePropertyexpose to security vuln.ObjectPropertyAccessor#setPossiblePropertyhas a fallback mechanism usinggetWriteMethodwhich also lack member access rights checkChanges/ Solution
OgnlRuntime#setFieldValuethat is controlled by parametercheckAccessAndExistenceObjectPropertyAccessor#setPossiblePropertycode block that usesOgnlRuntime#getWriteMethodResult & Impact
now
ObjectPropertyAccessor#setPossiblePropertywill also check member access rights when fallback to use: