Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark-11158][SQL] Modified _verify_type() to be more informative on Errors by presenting the Object #9149

Closed
wants to merge 3 commits into from

Conversation

lababidi
Copy link
Contributor

The _verify_type() function had Errors that were raised when there were Type conversion issues but left out the Object in question. The Object is now added in the Error to reduce the strain on the user to debug through to figure out the Object that failed the Type conversion.

The use case for me was a Pandas DataFrame that contained 'nan' as values for columns of Strings.

@andrewor14
Copy link
Contributor

@lababidi please file a JIRA and add it to the title of the PR. See how other PRs are opened.

@lababidi lababidi changed the title Modified _verify_type() to be more informative on Errors by presenting the Object [Spark-11158][SQL] Modified _verify_type() to be more informative on Errors by presenting the Object Oct 16, 2015
@JoshRosen
Copy link
Contributor

Jenkins, this is ok to test.

@JoshRosen
Copy link
Contributor

LGTM.

@SparkQA
Copy link

SparkQA commented Oct 18, 2015

Test build #43896 has finished for PR 9149 at commit e6c7a2a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor

I'm going to merge this into master. Thanks!

@asfgit asfgit closed this in a337c23 Oct 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants