Skip to content

[SPARK-8787][SQL]Changed parameter order of @deprecated in package object sql #7183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vinodkc wants to merge 2 commits into from
Closed

[SPARK-8787][SQL]Changed parameter order of @deprecated in package object sql #7183

vinodkc wants to merge 2 commits into from

Conversation

@vinodkc
Copy link
Contributor

@vinodkc vinodkc commented Jul 2, 2015

Parameter order of @deprecated annotation in package object sql is wrong

deprecated("1.3.0", "use DataFrame") .

This has to be changed to deprecated("use DataFrame", "1.3.0")

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 2, 2015

Can one of the admins verify this patch?

@sarutak
Copy link
Member

sarutak commented Jul 2, 2015

ok to test.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 2, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 2, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented Jul 2, 2015

Test build #36374 has started for PR 7183 at commit 700911c.

@sarutak
Copy link
Member

sarutak commented Jul 2, 2015

Thanks for reporting this issue @vinodkc. Could you add a brief description?

@vinodkc
Copy link
Contributor Author

vinodkc commented Jul 2, 2015

Added description

@sarutak
Copy link
Member

sarutak commented Jul 2, 2015

Thanks. I'll merge this once the test pass.

sarutak
sarutak reviewed Jul 2, 2015
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/package.scala Outdated
Copy link
Member

@sarutak sarutak Jul 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put the warning message just like "Use DataFrame" as with any other warning messages.

Copy link
Contributor Author

@vinodkc vinodkc Jul 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the message to "use DataFrame"

@SparkQA
Copy link

SparkQA commented Jul 2, 2015

Test build #36374 has finished for PR 7183 at commit 700911c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 2, 2015

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 2, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 2, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented Jul 2, 2015

Test build #36387 has started for PR 7183 at commit 1cbdbe8.

@SparkQA
Copy link

SparkQA commented Jul 2, 2015

Test build #36387 has finished for PR 7183 at commit 1cbdbe8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 2, 2015

Merged build finished. Test PASSed.

asfgit pushed a commit that referenced this pull request Jul 2, 2015
@srowen
[SPARK-8787] [SQL] Changed parameter order of @deprecated in package …
eb0dd45 
…object sql

Parameter order of deprecated annotation in package object sql is wrong
>>deprecated("1.3.0", "use DataFrame") .

This has to be changed to deprecated("use DataFrame", "1.3.0")

Author: Vinod K C <vinod.kc@huawei.com>

Closes #7183 from vinodkc/fix_deprecated_param_order and squashes the following commits:

1cbdbe8 [Vinod K C] Modified the message
700911c [Vinod K C] Changed order of parameters

(cherry picked from commit c572e25)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@asfgit asfgit closed this in c572e25 Jul 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vinodkc @AmplabJenkins @sarutak @SparkQA