[SPARK-50137][SQL] Avoid fallback to Hive-incompatible ways when table creation fails by thrift exception #50985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le creation fails by thrift exception
dongjoon-hyun
changed the title
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 22, 2025
…e creation fails by thrift exception ### What changes were proposed in this pull request? Enhance the datasource table creation, do not fallback to hive incompatible way if failure was caused by thrift exception. ### Why are the changes needed? Thrift exception is unrelated to hive compatibility of datasource table, so fallback is unnecessary in this case. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add a unit test: ```bash mvn test -Dtest=none -Dsuites="org.apache.spark.sql.hive.HiveExternalCatalogSuite SPARK-50137: Avoid fallback to Hive-incompatible ways on thrift exception" -pl :spark-hive_2.13 ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #50985 from wecharyu/SPARK-50137_2. Authored-by: wecharyu <yuwq1996@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit de3d44d) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Merged to master/4.0. If you want this in branch-3.5, please make a backporting PR. I couldn't backport directly because there is a code conflict, @wecharyu . |
|
I assigned SPARK-50137 to you. Thank you for your contribution. |
|
thank you @wecharyu for the quick fix |
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
…e creation fails by thrift exception ### What changes were proposed in this pull request? Enhance the datasource table creation, do not fallback to hive incompatible way if failure was caused by thrift exception. ### Why are the changes needed? Thrift exception is unrelated to hive compatibility of datasource table, so fallback is unnecessary in this case. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add a unit test: ```bash mvn test -Dtest=none -Dsuites="org.apache.spark.sql.hive.HiveExternalCatalogSuite SPARK-50137: Avoid fallback to Hive-incompatible ways on thrift exception" -pl :spark-hive_2.13 ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50985 from wecharyu/SPARK-50137_2. Authored-by: wecharyu <yuwq1996@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enhance the datasource table creation, do not fallback to hive incompatible way if failure was caused by thrift exception.
Why are the changes needed?
Thrift exception is unrelated to hive compatibility of datasource table, so fallback is unnecessary in this case.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add a unit test:
Was this patch authored or co-authored using generative AI tooling?
No.