-
Notifications
You must be signed in to change notification settings - Fork 28.6k
[Spark-5068][SQL]Fix bug query data when path doesn't exist for HiveContext #5059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
41f60ce
Merge pull request #1 from apache/master
lazyman500 04c443c
SPARK-5068: fix bug when partition path doesn't exists #2
lazyman500 47e0023
fix scala style,add config flag,break the chaining
lazyman500 f23133f
bug fix
lazyman500 e1d6386
fix scala style
lazyman500 5bfcbfd
move spark.sql.hive.verifyPartitionPath to SQLConf,fix scala style
lazyman500 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
sql/hive/src/test/scala/org/apache/spark/sql/hive/QueryPartitionSuite.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.spark.sql.hive | ||
|
||
import java.io.File | ||
|
||
import com.google.common.io.Files | ||
import org.apache.spark.sql.{QueryTest, _} | ||
import org.apache.spark.sql.hive.test.TestHive | ||
import org.apache.spark.util.Utils | ||
/* Implicits */ | ||
import org.apache.spark.sql.hive.test.TestHive._ | ||
|
||
|
||
|
||
class QueryPartitionSuite extends QueryTest { | ||
import org.apache.spark.sql.hive.test.TestHive.implicits._ | ||
|
||
test("SPARK-5068: query data when path doesn't exists"){ | ||
val testData = TestHive.sparkContext.parallelize( | ||
(1 to 10).map(i => TestData(i, i.toString))).toDF() | ||
testData.registerTempTable("testData") | ||
|
||
val tmpDir = Files.createTempDir() | ||
//create the table for test | ||
sql(s"CREATE TABLE table_with_partition(key int,value string) PARTITIONED by (ds string) location '${tmpDir.toURI.toString}' ") | ||
sql("INSERT OVERWRITE TABLE table_with_partition partition (ds='1') SELECT key,value FROM testData") | ||
sql("INSERT OVERWRITE TABLE table_with_partition partition (ds='2') SELECT key,value FROM testData") | ||
sql("INSERT OVERWRITE TABLE table_with_partition partition (ds='3') SELECT key,value FROM testData") | ||
sql("INSERT OVERWRITE TABLE table_with_partition partition (ds='4') SELECT key,value FROM testData") | ||
|
||
//test for the exist path | ||
checkAnswer(sql("select key,value from table_with_partition"), | ||
testData.toSchemaRDD.collect ++ testData.toSchemaRDD.collect | ||
++ testData.toSchemaRDD.collect ++ testData.toSchemaRDD.collect) | ||
|
||
//delect the path of one partition | ||
val folders = tmpDir.listFiles.filter(_.isDirectory) | ||
Utils.deleteRecursively(folders(0)) | ||
|
||
//test for affter delete the path | ||
checkAnswer(sql("select key,value from table_with_partition"), | ||
testData.toSchemaRDD.collect ++ testData.toSchemaRDD.collect | ||
++ testData.toSchemaRDD.collect) | ||
|
||
sql("DROP TABLE table_with_partition") | ||
sql("DROP TABLE createAndInsertTest") | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very long. I'd break the chaining here and have another variable.