[SPARK-50385][CORE] Use class name prefix for REST Submission API thread pool#48924
[SPARK-50385][CORE] Use class name prefix for REST Submission API thread pool#48924dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
Conversation
|
Could you review this PR, @panbingkun ? |
|
LGTM, +1 |
| */ | ||
| private def doStart(startPort: Int): (Server, Int) = { | ||
| val threadPool = new QueuedThreadPool(masterConf.get(MASTER_REST_SERVER_MAX_THREADS)) | ||
| threadPool.setName(getClass().getSimpleName()) |
|
Thank you so much, @panbingkun . |
|
All tests passed already in the first commit, 6c9bdd1. I just resolved the conflicts. Since this is a one-liner PR, could you try to merge this PR via the following script, @panbingkun ? |
yaooqinn
left a comment
There was a problem hiding this comment.
+1, LGTM, thank you @dongjoon-hyun
Okay, let me try, Thank you very much for providing me with such detailed guidance, ❤️! |
|
Merged to master. |
|
Thank you again to @dongjoon-hyun for guiding me step by step towards progress ❤️ ! |
|
Thank you, @panbingkun and @yaooqinn . To @panbingkun , I'm happy we are in the same Spark community! 😄
|


What changes were proposed in this pull request?
This PR aims to use a meaningful class name prefix for REST Submission API thread pool instead of the default value of Jetty QueuedThreadPool,
"qtp"+super.hashCode().https://github.com/dekellum/jetty/blob/3dc0120d573816de7d6a83e2d6a97035288bdd4a/jetty-util/src/main/java/org/eclipse/jetty/util/thread/QueuedThreadPool.java#L64
Why are the changes needed?
This is helpful during JVM investigation.
BEFORE (4.0.0-preview2)
AFTER
Does this PR introduce any user-facing change?
No, the thread names are accessed during the debugging.
How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
No.