[SPARK-49924][SQL] Keep containsNull after ArrayCompact replacement
#48410
+38
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
commented
Oct 10, 2024
| val array1 = ArrayCompact(CreateArray(Literal(1) :: Literal.apply(null) :: Nil, false)) | ||
| val plan1 = Project(Alias(array1, "arr")() :: Nil, OneRowRelation()).analyze | ||
| val optimized1 = optimizer.execute(plan1) | ||
| assert(plan1.schema === optimized1.schema) |
There was a problem hiding this comment.
before the fix, fails with
[info] StructType(StructField("arr", ArrayType(IntegerType, false), false, {})) did not equal StructType(StructField("arr", ArrayType(IntegerType, true), false, {})) (OptimizerSuite.scala:327)
zhengruifeng
commented
Oct 10, 2024
| val array2 = ArrayCompact(CreateArray(struct :: Literal.apply(null) :: Nil, false)) | ||
| val plan2 = Project(Alias(MapFromEntries(array2), "map")() :: Nil, OneRowRelation()).analyze | ||
| val optimized2 = optimizer.execute(plan2) | ||
| assert(plan2.schema === optimized2.schema) |
There was a problem hiding this comment.
before the fix, fails with:
[info] StructType(StructField("map", MapType(IntegerType, IntegerType, false), false, {})) did not equal StructType(StructField("map", MapType(IntegerType, IntegerType, false), true, {})) (OptimizerSuite.scala:333)
There was a problem hiding this comment.
I think we should explicitly write out the expected schema. Most cases the schema of RuntimeReplaceable and its replacement have the same schema.
zhengruifeng
changed the title
containsNull of ArrayCompactcontainsNull of ArrayCompact after replacement
zhengruifeng
force-pushed
the
fix_array_compact_null
branch
from
93e3fb5
to
39e5616
Compare
zhengruifeng
changed the title
containsNull of ArrayCompact after replacementcontainsNull after ArrayCompact replacement
zhengruifeng
force-pushed
the
fix_array_compact_null
branch
from
5af26f9
to
758c58e
Compare
zhengruifeng
force-pushed
the
fix_array_compact_null
branch
from
758c58e
to
1e75aa5
Compare
cloud-fan
approved these changes
Oct 11, 2024
yaooqinn
approved these changes
Oct 12, 2024
HyukjinKwon
approved these changes
Oct 12, 2024
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix
containsNullofArrayCompact, by adding a new expressionKnownNotContainsNullWhy are the changes needed?
#47430 attempted to set
containsNull = falseforArrayCompactfor further optimization, but in an incomplete way:The
ArrayCompactis a runtime replaceable expression, so will be replaced in optimizer, and cause thecontainsNullbe reverted, e.g.Rule
ReplaceExpressionschangedcontainsNull: false -> trueDoes this PR introduce any user-facing change?
no
How was this patch tested?
added tests
Was this patch authored or co-authored using generative AI tooling?
no