Skip to content

[Streaming][Minor] Remove useless type signature of Java Kafka direct stream API #4817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jerryshao
Copy link
Contributor

cc @tdas .

@SparkQA
Copy link

SparkQA commented Feb 27, 2015

Test build #28082 has started for PR 4817 at commit eebfaac.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 27, 2015

Test build #28082 has finished for PR 4817 at commit eebfaac.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • logError("User class threw exception: " + cause.getMessage, cause)

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28082/
Test PASSed.

@tdas
Copy link
Contributor

tdas commented Feb 27, 2015

Very good catch!! It is called from Java unit tests, I am not sure how we did not catch this. Maybe because I dont explicitly specify the generic params.

I am merging this to make sure this gets into Spark 1.3 RC2, but could you make another PR to fix the Java unit tests (specify types) so that such issues get caught?

asfgit pushed a commit that referenced this pull request Feb 27, 2015
… stream API

cc tdas .

Author: Saisai Shao <saisai.shao@intel.com>

Closes #4817 from jerryshao/signature-minor-fix and squashes the following commits:

eebfaac [Saisai Shao] Remove useless type parameter

(cherry picked from commit 5f7f3b9)
Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
@asfgit asfgit closed this in 5f7f3b9 Feb 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants