Skip to content

[SPARK-5335] Fix deletion of security groups within a VPC #4122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-5335] Fix deletion of security groups within a VPC #4122

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
730ec05
fix for SPARK-5335: Destroying cluster in VPC with "--delete-groups" …
Jan 20, 2015
090dca9
fixes as per review: removed printing of group_id and added comment
Feb 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ec2/spark_ec2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1082,11 +1082,12 @@ def real_main():
time.sleep(30) # Yes, it does have to be this long :-(
for group in groups:
try:
conn.delete_security_group(group.name)
print "Deleted security group " + group.name
# It is needed to use group_id to make it work with VPC
conn.delete_security_group(group_id=group.id)
print "Deleted security group %s" % group.name
except boto.exception.EC2ResponseError:
success = False
print "Failed to delete security group " + group.name
print "Failed to delete security group %s" % group.name

# Unfortunately, group.revoke() returns True even if a rule was not
# deleted, so this needs to be rerun if something fails
Expand Down