[SPARK-41862][SQL][TESTS][FOLLOWUP] Update OrcReadBenchmark result #39380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
commented
Jan 4, 2023
Member
Author
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
This is simply the updated result on the patch. Could you review this, @dtenedor and @HyukjinKwon .
dongjoon-hyun
commented
Jan 4, 2023
| Native ORC Vectorized 93062 93335 386 0.0 88750.4 0.3X | ||
| Hive built-in ORC 36374 37652 1808 0.0 34688.9 1.0X | ||
| Native ORC MR 30738 31431 980 0.0 29313.9 1.2X | ||
| Native ORC Vectorized 27877 28169 413 0.0 26585.4 1.3X |
Member
Author
There was a problem hiding this comment.
This is the fixed result. Thank you again, @dtenedor . I'm happy to have this fix at Apache Spark 3.4.0.
HyukjinKwon
approved these changes
Jan 4, 2023
dtenedor
approved these changes
Jan 4, 2023
Contributor
dtenedor
left a comment
dtenedor
left a comment
There was a problem hiding this comment.
LGTM from my end as well
Member
Author
|
Thank you, @LuciferYang , @HyukjinKwon , @dtenedor . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a follow-up of #39370 .
Why are the changes needed?
To sync the patch with the recovered perf result.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual review.